Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open merge UIs to librarians #6920

Merged

Conversation

jimchamp
Copy link
Collaborator

@jimchamp jimchamp commented Aug 30, 2022

Closes #6883

Permits members of /usergroup/librarians to access author and work merge views. librarians now submit merge requests (MRs) from these UIs, instead of search results pages.

The primary work ID can now be included for work MRs. If a work merge URL has a primary ID, that record will appear first in the list of all records.

Technical

Special Deployment Instructions

The openlibrary.yml configuration files must be updated in production, testing, and staging before this is deployed.

Testing

Screenshot

Stakeholders

@jimchamp jimchamp added the Needs: Special Deploy This PR will need a non-standard deploy to production label Aug 30, 2022
@mekarpeles mekarpeles self-assigned this Aug 31, 2022
@mekarpeles mekarpeles added Priority: 1 Do this week, receiving emails, time sensitive, . [managed] and removed Needs: Special Deploy This PR will need a non-standard deploy to production labels Sep 6, 2022
@mekarpeles
Copy link
Member

To test, create an account with just librarian access and attempt to propose an author + work merge --> goes to UI instead of toast msg

@mekarpeles mekarpeles merged commit 5e4e4b9 into internetarchive:master Sep 14, 2022
@jimchamp jimchamp deleted the 6883/feature/adjust-mr-flow branch November 4, 2022 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 1 Do this week, receiving emails, time sensitive, . [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate "Request Merge" from the Search Results page to the Merge UI
2 participants