Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use prop in correct way for mergeUI #8315

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Conversation

RayBB
Copy link
Collaborator

@RayBB RayBB commented Sep 20, 2023

this.isSuperLibrarian() -> this.isSuperLibrarian
Just like we use in the rest of the file.

Was found as an issue via the updated linter #8312
https://eslint.vuejs.org/rules/no-use-computed-property-like-method.html

Not sure if it was actually causing a bug. But I figured we should pull it into a separate PR to avoid extra discussion there.

Technical

Testing

Screenshot

Stakeholders

@jimchamp can you please check this one? (Since this was your code in #6920)

@codecov-commenter
Copy link

Codecov Report

Merging #8315 (a4315b5) into master (a4975ab) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8315   +/-   ##
=======================================
  Coverage   16.99%   16.99%           
=======================================
  Files          75       75           
  Lines        3942     3942           
  Branches      674      674           
=======================================
  Hits          670      670           
  Misses       2842     2842           
  Partials      430      430           

@jimchamp
Copy link
Collaborator

jimchamp commented Sep 21, 2023

Sorry for the delay, @RayBB. You're right, that was no way to access a computed property in Vue. Luckily, this bug should have only affected the status message that is displayed after a merge.

@jimchamp jimchamp merged commit b00ebf1 into internetarchive:master Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants