Remove unused subjects.js #8783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrini
force-pushed
the
refactor/rm-subjects-js
branch
from
a2de179 to
baeb0cc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8783 +/- ##
==========================================
- Coverage 16.62% 16.29% -0.33%
==========================================
Files 88 87 -1
Lines 4698 4596 -102
Branches 838 811 -27
==========================================
- Hits 781 749 -32
+ Misses 3399 3342 -57
+ Partials 518 505 -13 ☔ View full report in Codecov by Sentry. |
cdrini
added
the
On testing.openlibrary.org
|
@cdrini did we test the published graph? e.g. selecting regions and seeing if the subjects page reloads w/ the right queries? |
mekarpeles
added
the
Needs: Submitter Input
|
Yep! Works as it did :) |
cdrini
removed
the
Needs: Submitter Input
|
It's up on testing.openlibrary.org |
jimchamp
approved these changes
Feb 22, 2024
jimchamp
removed
the
On testing.openlibrary.org
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor. Found no references to
Subject(in the js or in the python referencing this object. My guess was this was an attempted restructure which was never actually switched to/used.Technical
Testing
Screenshot
Stakeholders