Remove unused subjects.js

openlibrary/plugins/openlibrary/js/index.js

@@ -15,8 +15,7 @@ import { enumerate, htmlquote, websafe, foreach, join, len, range } from './jsde
 import initAnalytics from './ol.analytics';
 import init from './ol.js';
 import * as Browser from './Browser';
-import { commify } from './python';
-import { Subject, urlencode, slice } from './subjects';
+import { commify, urlencode, slice } from './python';
 import Template from './template.js';
 // Add $.fn.focusNextInputField
 import { truncate, cond } from './utils';
@@ -45,7 +44,6 @@ window.ungettext = ungettext;
 window.uggettext = ugettext;
 
 window.Browser = Browser;
-window.Subject = Subject;
 window.Template = Template;
 
 // Extend existing prototypes

openlibrary/plugins/openlibrary/js/python.js

@@ -17,3 +17,22 @@ export function commify(n) {
 
     return text;
 }
+
+// Implementation of Python urllib.urlencode in Javascript.
+export function urlencode(query) {
+    var parts = [];
+    var k;
+    for (k in query) {
+        parts.push(`${k}=${query[k]}`);
+    }
+    return parts.join('&');
+}
+
+export function slice(array, begin, end) {
+    var a = [];
+    var i;
+    for (i=begin; i < Math.min(array.length, end); i++) {
+        a.push(array[i]);
+    }
+    return a;
+}

tests/unit/js/python.test.js

@@ -1,4 +1,4 @@
-import { commify } from '../../../openlibrary/plugins/openlibrary/js/python';
+import { commify, urlencode, slice } from '../../../openlibrary/plugins/openlibrary/js/python';
 
 test('commify', () => {
     expect(commify('5443232')).toBe('5,443,232');
@@ -7,3 +7,33 @@ test('commify', () => {
     expect(commify(['1','2','3','45'])).toBe('1,2,3,45');
     expect(commify([1, 20, 3])).toBe('1,20,3');
 });
+
+describe('urlencode', () => {
+    test('empty array', () => {
+        expect(urlencode([])).toEqual('');
+    });
+    test('array of 1', () => {
+        expect(urlencode(['apple'])).toEqual('0=apple');
+    });
+    test('array of 3', () => {
+        expect(urlencode(['apple', 'grapes', 'orange'])).toEqual('0=apple&1=grapes&2=orange');
+    });
+});
+
+describe('slice', () => {
+    test('empty array', () => {
+        expect(slice([], 0, 0)).toEqual([]);
+    });
+    test('array of 2', () => {
+        expect(slice([1, 2], 0, 1)).toEqual([1]);
+    });
+    test('arr length less than end', () => {
+        expect(slice([1, 2, 3], 0, 5)).toEqual([1, 2, 3]);
+    });
+    test('beginning greater than end', () => {
+        expect(slice([1, 2, 3, 4, 5], 4, 3)).toEqual([]);
+    });
+    test('array of 5', () => {
+        expect(slice([1, 2, 3, 4, 5], 0, 3)).toEqual([1, 2, 3]);
+    });
+});