Add [alt] attributes to images #9644
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrini
reviewed
Jul 29, 2024
Comment on lines
35
to
39
| <span class="nav-arrow"> | ||
| <img src="/static/images/nav-arrow.svg" role="img"> | ||
| <button title="$_('Go to next section')"> | ||
| <img src="/static/images/nav-arrow.svg" alt=""> | ||
| </button> | ||
| </span> |
There was a problem hiding this comment.
Heads up: This was meant to replace the span with the button, and you'll have to update some the CSS as well
Souvik-Cyclic
force-pushed
the
9629/detailing/img-alt-addon
branch
from
0c5185f to
6f8416a
Compare
for more information, see https://pre-commit.ci
8 tasks
jimchamp
requested changes
Aug 14, 2024
There was a problem hiding this comment.
Thanks for your patience, @Souvik-Cyclic!
This is mostly good. The styling of the Go to next section button will need to be updated before this can be merged in.
jimchamp
added
the
Needs: Submitter Input
Co-authored-by: jimchamp <28732543+jimchamp@users.noreply.github.com>
github-actions
bot
removed
the
Needs: Submitter Input
* Hide download options when book is unavailable.
updates: - [github.com/astral-sh/ruff-pre-commit: v0.5.4 → v0.5.5](astral-sh/ruff-pre-commit@v0.5.4...v0.5.5) - [github.com/pre-commit/mirrors-eslint: v9.7.0 → v9.8.0](pre-commit/mirrors-eslint@v9.7.0...v9.8.0)
The Slack channel string begins with a `#` character. Quoting this string prevents the channel from being parsed as comment on script execution.
…rchive#9626) * Altered BulkSearch to handle abstractors in their own class, rather than as a part of the vue component. * Adjusted samplebar selector to directly load based off of the 'extractors' array.
* Add wikisource provider
…archive#9687) * update description of alternate names on author edit page
This commit stops non-DirectProvider web books from being matched as `DirectProvider`s. The `Storage` objects that ultimately come from `SearchResponse` have `Acquisition` objects in their `providers` fields, so every web book search result will have a `providers` attribute. This commit limits the matching for `DirectProvider` to cases where the `Acquisition` object has a value other than `None`, which is the default initialization value for `Acquisition.provider_name`. More exploration will be needed to see whether a similar mis-match problem occurs when there is more than one `Acquisition` per `Work`.
The `direct_read_button.html` needs a unique `data-toast-trigger` per domain, otherwise every `DirectProvider` book, when multiple are displayed from different providers, will have trigger the same class id.
When an import record is "incomplete" per internetarchive#9440, this commit will look to the `import_item` table to supplement that `rec` with data loaded by BookWorm. This attempt to supplement will apply to any import source if one of the required-for-completeness fields (title, authors, publish_date) is missing. See internetarchive#9440.
This commit changes `promise_batch_imports.py` so that it no longer adds variations of `????` in place of the following empty fields: - `authors` - `publish_date` - `title` These fields are once again required for all imports, including promise items. `????` will also no longer be removed from these fields when importing. When one of these fields is missing, a request is made to BookWorm to stage the item for import, if metadata can be found. A companion commit changes the import process so if one of the above required fields is missing, it will look to the `import_table` for `pending` or `staged` metadata. See internetarchive#9440.
This commit updates the `statsd` wrapper to add support for the `gauge` data type, and makes use of it to add a `gauge` to promise item imports so that we can know, per batch, the complete/incomplete rate.
This commit changes the import requirements such that a record must either be: 1. complete, or 2. differentiable. See internetarchive#9440 for the definitions.
Co-authored-by: Scott Barnes <scottreidbarnes@gmail.com>
|
I fixed the indentation, but I had trouble adjusting the button's styling. I tried changing the CSS, but the changes didn't take effect. @jimchamp, could you help me with this? |
|
Sure! Every time a change is made to a docker compose exec web make cssMore information about developing Open Library's front-end can be found here. |
jimchamp
added
the
Needs: Submitter Input
github-actions
bot
removed
the
Needs: Submitter Input
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9644 +/- ##
==========================================
+ Coverage 16.06% 16.70% +0.64%
==========================================
Files 90 90
Lines 4769 4824 +55
Branches 832 841 +9
==========================================
+ Hits 766 806 +40
- Misses 3480 3494 +14
- Partials 523 524 +1 ☔ View full report in Codecov by Sentry. |
|
I am closing this PR due to an error on my part. I will submit a new one shortly. New PR #9761 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9629
Adds [alt] attributes to images for Improving Accessibility Score of Book Pages
Stakeholders
@cdrini