Add [alt] attributes to images

[Souvik-Cyclic]

Closes #9629

Adds [alt] attributes to images for Improving Accessibility Score of Book Pages

Screenshot

Stakeholders

@jimchamp

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.42%. Comparing base (ce16a79) to head (9741d29).
Report is 356 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #9761      +/-   ##
==========================================
+ Coverage   16.06%   16.42%   +0.36%     
==========================================
  Files          90       92       +2     
  Lines        4769     4907     +138     
  Branches      832      856      +24     
==========================================
+ Hits          766      806      +40     
- Misses       3480     3565      +85     
- Partials      523      536      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jimchamp]

Thanks @Souvik-Cyclic! I'm happy to merge this once the review notes have been addressed.

[jimchamp]

Suggested change

	$def icon_link(link_class, img_src, link_text, login_redirect=True, ga_data=None, alt=""):
	$def icon_link(link_class, img_src, link_text, login_redirect=True, ga_data=None):

It isn't necessary to add alt here, as it will be the same value for each modal link.

[Souvik-Cyclic]

removing it from here is causing some issues on the page.

[jimchamp]

Oh! I see why this is happening. The alt keyword argument needs to be removed from the icon_link call on line 28. I overlooked that one during my review...

Let me test what you have now, and I can make a final commit to this branch that will remove the argument.

[Souvik-Cyclic]

@jimchamp review notes have been addressed, Wait there are some errors, need to fix it.

[jimchamp]

Thanks for the quick updates! I noticed that the nav-arrow changes affected that element's styling a good bit. Can you update the CSS for that, and push up the changes? Apologies for missing this earlier.

Edit: In order to test these changes, the .less files need to be compiled to CSS. You can do this by running docker compose exec web make css while the webapp is running.