Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve EPP login #1314

Merged
merged 15 commits into from
Nov 13, 2020
Merged

Improve EPP login #1314

merged 15 commits into from
Nov 13, 2020

Conversation

artur-intech
Copy link
Contributor

@artur-intech artur-intech commented Sep 13, 2019

@artur-intech artur-intech changed the title Improve epp login Improve EPP login Sep 13, 2019
@vohmar
Copy link
Contributor

vohmar commented Sep 17, 2019

#587 test failed - user is able to log in unlimited number of times. Cannot find how to set the session limit (#543) - unable to test nor verify

@artur-intech
Copy link
Contributor Author

artur-intech commented Sep 17, 2019

#587 test failed - user is able to log in unlimited number of times. Cannot find how to set the session limit (#543) - unable to test nor verify

Well, then it either means session limit per registrar never worked or there is something wrong with EPP proxy integration, since this PR only changes response code and does not touch any logic. I will check.

@artur-intech
Copy link
Contributor Author

I need detailed description of how you test it.

@artur-intech artur-intech assigned vohmar and unassigned artur-intech Sep 17, 2019
@artur-intech
Copy link
Contributor Author

#729

@vohmar
Copy link
Contributor

vohmar commented Sep 18, 2019

#1313 is ok, second attempt to login in already auhtenitaed session resulted in error 2002 as expected.
#587 is still an issue - set the auth limit on application.yml to 4, sessions db table is clear, but user is still able to create more than 4 parallel sessions - in our test example 7 active sessions were created. To test, user form the same ip opens up multiple sessions directly to the epp interface (epptelnet)

@vohmar vohmar assigned artur-intech and unassigned vohmar Sep 18, 2019
@artur-intech
Copy link
Contributor Author

See my previous comment.

@artur-intech
Copy link
Contributor Author

#1331 should help.

@artur-intech artur-intech assigned vohmar and unassigned artur-intech Sep 18, 2019
@vohmar vohmar added the blocked label Oct 8, 2019
@vohmar
Copy link
Contributor

vohmar commented Oct 8, 2019

blocked by #1331

@vohmar vohmar removed their assignment Jan 3, 2020
@teadur teadur marked this pull request as draft August 18, 2020 19:40
@yulgolem yulgolem self-assigned this Sep 3, 2020
@yulgolem
Copy link
Contributor

yulgolem commented Sep 4, 2020

@ratM1n let's check this branch on staging.
Locally 5th login attempt with non-expired sessions goes 2502:Session limit exceeded; server closing connection (connection limit reached).

@yulgolem yulgolem marked this pull request as ready for review September 4, 2020 11:38
@ratM1n
Copy link

ratM1n commented Nov 12, 2020

Did I miss something, but after adding epp_sessions_per_registrar: '4' to application.yml and restart, I'm getting on login:

<result code="2502"> <msg lang="en">Session limit exceeded; server closing connection (connection limit reached)</msg> </result>

@ratM1n ratM1n assigned yulgolem and unassigned ratM1n Nov 12, 2020
@yulgolem yulgolem assigned ratM1n and unassigned yulgolem Nov 13, 2020
@ratM1n
Copy link

ratM1n commented Nov 13, 2020

OK! seems to work correctly and also ignore expired sessions if present in database.

@ratM1n ratM1n requested a review from vohmar November 13, 2020 09:55
@ratM1n ratM1n assigned vohmar and unassigned ratM1n Nov 13, 2020
@vohmar vohmar merged commit 71991f7 into master Nov 13, 2020
@vohmar vohmar deleted the improve-epp-login branch November 20, 2020 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Authenticated EPP user is able to login repeatedly
5 participants