Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EPP session timeout #1331

Merged
merged 5 commits into from
Sep 3, 2020
Merged

Fix EPP session timeout #1331

merged 5 commits into from
Sep 3, 2020

Conversation

artur-intech
Copy link
Contributor

@artur-intech artur-intech commented Sep 18, 2019

@ratM1n @teadur

Fixes #711

@artur-intech artur-intech force-pushed the fix-epp-session-timeout branch from aff96ed to 0fa9575 Compare September 18, 2019 15:28
@artur-intech artur-intech changed the title Fix epp session timeout Fix EPP session timeout Sep 18, 2019
@artur-intech artur-intech force-pushed the fix-epp-session-timeout branch 2 times, most recently from c56924a to 2376481 Compare September 18, 2019 15:41
@artur-intech artur-intech mentioned this pull request Sep 18, 2019
@vohmar vohmar assigned artur-intech and unassigned vohmar Sep 20, 2019
@artur-intech artur-intech force-pushed the fix-epp-session-timeout branch from 2376481 to def974a Compare September 30, 2019 12:59
@teadur
Copy link
Contributor

teadur commented Sep 30, 2019

@artur-beljajev why does not running the cleanup break logging in ?
Whats the behviour when i just restart the application ?

@artur-intech
Copy link
Contributor Author

@teadur

  • Why any logging is needed here?
  • Behavior is not dependent on restart

@vohmar vohmar assigned teadur and unassigned artur-intech Oct 3, 2019
@vohmar
Copy link
Contributor

vohmar commented Oct 7, 2019

this branch returns this error on running passenger:
[Mon Oct 07 10:38:20 2019] [crit] [client 192.168.2.45] configuration error: couldn't perform authentication. AuthType not set!: /epp/session/hello

this is from Apache log - starting application fails.

@vohmar vohmar assigned artur-intech and unassigned teadur Oct 7, 2019
@artur-intech artur-intech force-pushed the fix-epp-session-timeout branch from def974a to a8f185c Compare October 16, 2019 10:50
@artur-intech
Copy link
Contributor Author

artur-intech commented Oct 16, 2019

[Mon Oct 07 10:38:20 2019] [crit] [client 192.168.2.45] configuration error: couldn't perform authentication. AuthType not set!: /epp/session/hello

@ratM1n
Does the issue still persist? If so, then something is misconfigured on server side. Are there some mod_epp remnants?

@artur-intech artur-intech assigned ratM1n and unassigned artur-intech Oct 16, 2019
@teadur teadur added this to the Featurecomplete EPP milestone Aug 18, 2020
@teadur teadur marked this pull request as draft August 18, 2020 19:39
@yulgolem yulgolem force-pushed the fix-epp-session-timeout branch from a8f185c to 9baa65a Compare August 31, 2020 08:37
@yulgolem yulgolem force-pushed the fix-epp-session-timeout branch from c21d247 to 16db735 Compare August 31, 2020 08:58
@yulgolem yulgolem marked this pull request as ready for review August 31, 2020 09:03
@yulgolem
Copy link
Contributor

Fixed some style & tests, let's check this.

@vohmar
Copy link
Contributor

vohmar commented Sep 2, 2020

  • epp:clear_expired_sessions rake tasks clear epp_sessions table, while it should only remove expired sessions (where now - updated_at is more than epp_session_timeout_seconds)

@vohmar vohmar assigned yulgolem and unassigned ratM1n Sep 2, 2020
@yulgolem yulgolem assigned ratM1n and unassigned yulgolem Sep 3, 2020
@yulgolem
Copy link
Contributor

yulgolem commented Sep 3, 2020

The timeout variable was not set in the deploy script.
Added default timeout value of 300 sec, added test to see if task destroys only expired sessions.

@yulgolem yulgolem assigned vohmar and unassigned ratM1n Sep 3, 2020
@vohmar vohmar merged commit 85274ca into master Sep 3, 2020
@vohmar vohmar deleted the fix-epp-session-timeout branch September 8, 2020 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EPP session timeout does not end sessions
6 participants