Enable multiple entries in IP whitelist

#39
internetee · May 24, 2018 · 403fd7a · 403fd7a
1 parent 417adf3
commit 403fd7a
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/app/controllers/whois_records_controller.rb b/app/controllers/whois_records_controller.rb
@@ -46,7 +46,8 @@ def log_message(params, whois_record)
 
   def ip_in_whitelist?
     return unless ENV['whitelist_ip'].present?
-    ENV['whitelist_ip'] == request.remote_ip
+    whitelist = ENV['whitelist_ip'].split(',').map(&:strip)
+    whitelist.include?(request.remote_ip)
   end
 
   def captcha_solved?

diff --git a/config/application-example.yml b/config/application-example.yml
@@ -1,4 +1,4 @@
-whitelist_ip: '127.0.0.1'
+whitelist_ip: '127.0.0.1, 127.0.0.2'
 recaptcha_site_key: test
 recaptcha_secret_key: test
 

diff --git a/test/integration/whois_records/html_test.rb b/test/integration/whois_records/html_test.rb
@@ -275,4 +275,10 @@ def test_hide_sensitive_data_of_legal_entity_when_ip_is_not_in_whitelist
     )
     assert_button 'View full whois info'
   end
+
+  def test_multiple_entries_in_ip_whitelist
+    ENV['whitelist_ip'] = '127.0.0.1, 127.0.0.2'
+    visit '/v1/company-domain.test'
+    assert_no_text 'Not Disclosed'
+  end
 end