Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDPR: special access to registration data #39

Closed
vohmar opened this issue Apr 24, 2018 · 10 comments
Closed

GDPR: special access to registration data #39

vohmar opened this issue Apr 24, 2018 · 10 comments
Assignees

Comments

@vohmar
Copy link
Contributor

vohmar commented Apr 24, 2018

For contract partners like local CERT we will enable access to all domain registration details without capthca requirement and different rate limits.

Currently this is solved using an IP whitelist. We would like to add key based auth layer for extra security.

@vohmar
Copy link
Contributor Author

vohmar commented May 16, 2018

we will postpone the auth key implementation for the moment. The special ip white list based access should give access to all the data in the whois incl private registrars and their contacts.

@artur-intech artur-intech self-assigned this May 16, 2018
@artur-intech
Copy link
Contributor

artur-intech commented May 16, 2018

@artur-intech
Copy link
Contributor

Any reason why domains table exists in the DB?

create_table "domains", force: :cascade do |t|

@artur-intech
Copy link
Contributor

artur-intech commented May 18, 2018

So it's needed to make it so, that if I visit https://internet.ee say from CERT's IP, captcha should not be visible here? http://prntscr.com/jjcj0y

@vohmar
Copy link
Contributor Author

vohmar commented May 18, 2018

Basically yes, CERT will be using REST-WHOIS API to make their queries. The results will most probably not be completeley available using the whois search in internet.ee as this is designed interface for REST-WHOIS API and we do not plan any design changes in these views CERT special access in mind..

In staging we are talking about this: http://st.infra.tld.ee/v1/domain_name_here.ee

@artur-intech
Copy link
Contributor

artur-intech commented May 19, 2018

@maciej-szlosarczyk FYI There is a high risk of conflicts if you make some further changes in #37

@maciej-szlosarczyk
Copy link
Contributor

@artur-beljajev I wasn't planning to 😄. I'd leave #37 as is, test it ASAP, fix any bugs that might come under testing and merge it to master. You made some good comments, but unless they're critical/bugs, I'd just make it live and then improve afterwards in smaller steps. Among many things, #37 introduces complete test suite, which should remove the need for manual regression testing and allow us to iterate faster. Since there was 0 test coverage, I might as well started with rails new, and the result would've been the same.

I hindsight, I might've gone there a bit overboard with the number of changes I introduced there, I should've kept out the HAML part and maybe make the initial test suite its own branch.

@artur-intech
Copy link
Contributor

@vohmar I guess there should be support for multiple IPs in whitelist? Currently it is limited to single one.

@teadur
Copy link
Contributor

teadur commented May 21, 2018

@artur-beljajev Yes it should be possible to configure multiple ip's.

@artur-intech
Copy link
Contributor

artur-intech pushed a commit that referenced this issue May 24, 2018
artur-intech pushed a commit that referenced this issue May 24, 2018
artur-intech pushed a commit that referenced this issue May 24, 2018
artur-intech pushed a commit that referenced this issue May 24, 2018
artur-intech pushed a commit that referenced this issue May 24, 2018
artur-intech pushed a commit that referenced this issue May 24, 2018
artur-intech pushed a commit that referenced this issue May 24, 2018
artur-intech pushed a commit that referenced this issue May 24, 2018
artur-intech pushed a commit that referenced this issue May 24, 2018
artur-intech pushed a commit that referenced this issue May 24, 2018
@vohmar vohmar closed this as completed May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants