Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shipit): correct variable name isBaseBranch #1223

Merged
merged 1 commit into from
May 18, 2020

Conversation

bmuenzenmeyer
Copy link
Contributor

@bmuenzenmeyer bmuenzenmeyer commented May 18, 2020

While reading the source I noticed this typo

📦 Published PR as canary version: under canary scope @auto-canary@9.32.4-canary.1223.15713.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@9.32.4-canary.1223.15713.0
npm install @auto-canary/auto@9.32.4-canary.1223.15713.0
npm install @auto-canary/core@9.32.4-canary.1223.15713.0
npm install @auto-canary/all-contributors@9.32.4-canary.1223.15713.0
npm install @auto-canary/brew@9.32.4-canary.1223.15713.0
npm install @auto-canary/chrome@9.32.4-canary.1223.15713.0
npm install @auto-canary/cocoapods@9.32.4-canary.1223.15713.0
npm install @auto-canary/conventional-commits@9.32.4-canary.1223.15713.0
npm install @auto-canary/crates@9.32.4-canary.1223.15713.0
npm install @auto-canary/exec@9.32.4-canary.1223.15713.0
npm install @auto-canary/first-time-contributor@9.32.4-canary.1223.15713.0
npm install @auto-canary/gh-pages@9.32.4-canary.1223.15713.0
npm install @auto-canary/git-tag@9.32.4-canary.1223.15713.0
npm install @auto-canary/gradle@9.32.4-canary.1223.15713.0
npm install @auto-canary/jira@9.32.4-canary.1223.15713.0
npm install @auto-canary/maven@9.32.4-canary.1223.15713.0
npm install @auto-canary/npm@9.32.4-canary.1223.15713.0
npm install @auto-canary/omit-commits@9.32.4-canary.1223.15713.0
npm install @auto-canary/omit-release-notes@9.32.4-canary.1223.15713.0
npm install @auto-canary/released@9.32.4-canary.1223.15713.0
npm install @auto-canary/s3@9.32.4-canary.1223.15713.0
npm install @auto-canary/slack@9.32.4-canary.1223.15713.0
npm install @auto-canary/twitter@9.32.4-canary.1223.15713.0
npm install @auto-canary/upload-assets@9.32.4-canary.1223.15713.0
# or 
yarn add @auto-canary/bot-list@9.32.4-canary.1223.15713.0
yarn add @auto-canary/auto@9.32.4-canary.1223.15713.0
yarn add @auto-canary/core@9.32.4-canary.1223.15713.0
yarn add @auto-canary/all-contributors@9.32.4-canary.1223.15713.0
yarn add @auto-canary/brew@9.32.4-canary.1223.15713.0
yarn add @auto-canary/chrome@9.32.4-canary.1223.15713.0
yarn add @auto-canary/cocoapods@9.32.4-canary.1223.15713.0
yarn add @auto-canary/conventional-commits@9.32.4-canary.1223.15713.0
yarn add @auto-canary/crates@9.32.4-canary.1223.15713.0
yarn add @auto-canary/exec@9.32.4-canary.1223.15713.0
yarn add @auto-canary/first-time-contributor@9.32.4-canary.1223.15713.0
yarn add @auto-canary/gh-pages@9.32.4-canary.1223.15713.0
yarn add @auto-canary/git-tag@9.32.4-canary.1223.15713.0
yarn add @auto-canary/gradle@9.32.4-canary.1223.15713.0
yarn add @auto-canary/jira@9.32.4-canary.1223.15713.0
yarn add @auto-canary/maven@9.32.4-canary.1223.15713.0
yarn add @auto-canary/npm@9.32.4-canary.1223.15713.0
yarn add @auto-canary/omit-commits@9.32.4-canary.1223.15713.0
yarn add @auto-canary/omit-release-notes@9.32.4-canary.1223.15713.0
yarn add @auto-canary/released@9.32.4-canary.1223.15713.0
yarn add @auto-canary/s3@9.32.4-canary.1223.15713.0
yarn add @auto-canary/slack@9.32.4-canary.1223.15713.0
yarn add @auto-canary/twitter@9.32.4-canary.1223.15713.0
yarn add @auto-canary/upload-assets@9.32.4-canary.1223.15713.0

@codecov
Copy link

codecov bot commented May 18, 2020

Codecov Report

Merging #1223 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1223   +/-   ##
=======================================
  Coverage   80.95%   80.95%           
=======================================
  Files          54       54           
  Lines        3948     3948           
  Branches      852      852           
=======================================
  Hits         3196     3196           
  Misses        540      540           
  Partials      212      212           
Impacted Files Coverage Δ
packages/core/src/auto.ts 76.82% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8205cb...7f85199. Read the comment docs.

@hipstersmoothie hipstersmoothie added the internal Changes only affect the internal API label May 18, 2020
@hipstersmoothie hipstersmoothie merged commit 2a47b73 into intuit:master May 18, 2020
@adierkens
Copy link
Collaborator

🚀 PR was released in v9.33.0 🚀

@adierkens adierkens added the released This issue/pull request has been released. label May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes only affect the internal API released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants