Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shipit): correct variable name isBaseBranch #1223

Merged
merged 1 commit into from
May 18, 2020
Merged

fix(shipit): correct variable name isBaseBranch #1223

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/core/src/auto.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1394,7 +1394,7 @@ export default class Auto {
// env-ci sets branch to target branch (ex: master) in some CI services.
// so we should make sure we aren't in a PR just to be safe
const currentBranch = getCurrentBranch();
const isBaseBrach = !isPR && currentBranch === this.baseBranch;
const isBaseBranch = !isPR && currentBranch === this.baseBranch;
const shouldGraduate =
!options.onlyGraduateWithReleaseLabel ||
(options.onlyGraduateWithReleaseLabel &&
Expand All @@ -1411,7 +1411,7 @@ export default class Auto {

this.logger.veryVerbose.info({
currentBranch,
isBaseBrach,
isBaseBranch,
isPR,
shouldGraduate,
isPrereleaseBranch,
Expand All @@ -1421,7 +1421,7 @@ export default class Auto {

let releaseType: ShipitRelease = "canary";

if (isBaseBrach && shouldGraduate) {
if (isBaseBranch && shouldGraduate) {
releaseType = "latest";
} else if (this.inOldVersionBranch()) {
releaseType = "old";
Expand Down