Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ts error with react native 0.71 #709

Merged
merged 8 commits into from
Mar 13, 2023

Conversation

helenaford
Copy link
Member

@helenaford helenaford commented Mar 13, 2023

There's an issue with the latest react-native version (0.71+) where the d.ts file is incorrect. To get around this, added a @ts-ignore which is not ideal but the best solution until it is fixed in the core library

Opened up a p/r against react-native facebook/react-native#36462

Also, refreshes the example app with the latest react-native version

Fixes #708

@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Merging #709 (fc23670) into main (827b6b7) will not change coverage.
The diff coverage is 50.00%.

❗ Current head fc23670 differs from pull request most recent head 247c9a2. Consider uploading reports for the commit 247c9a2 to get more accurate results

@@           Coverage Diff           @@
##             main     #709   +/-   ##
=======================================
  Coverage   77.24%   77.24%           
=======================================
  Files          34       34           
  Lines        1700     1700           
  Branches      567      567           
=======================================
  Hits         1313     1313           
  Misses        386      386           
  Partials        1        1           

@helenaford helenaford merged commit 4204895 into main Mar 13, 2023
@helenaford helenaford deleted the helenaford/fix-ts-error-with-react-native-0.71 branch March 13, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot compile typescript usint react-native 0.71+
1 participant