fix: EventEmitter ts definition file

[helenaford]

Summary

There's an error in the d.ts file for EventEmitter which causes the following error:

This expression is not constructable.
  Type 'typeof import(".../vendor/emitter/EventEmitter")' has no construct signatures.
const emitter = new EventEmitter();
                      ~~~~~~~~~~~~

See

react-native/Libraries/vendor/emitter/EventEmitter.js

Line 63 in dce9d8d

export default class EventEmitter<TEventToArgsMap: {...}>

Changelog

Test Plan

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,519,172	+0
android	hermes	armeabi-v7a	7,834,700	+0
android	hermes	x86	8,999,506	+0
android	hermes	x86_64	8,854,758	+0
android	jsc	arm64-v8a	9,142,474	+0
android	jsc	armeabi-v7a	8,333,842	+0
android	jsc	x86	9,197,229	+0
android	jsc	x86_64	9,455,335	+0

Base commit: 803bb16
Branch: main

[NickGerleman]

From #36109 it seemed like we shouldn't be exposing EventEmitter at all, since we do not export it as part of our entrypoint for public APIs.

Are you seeing this error when trying to import this as a source file from RN directly by chance?

[helenaford]

@NickGerleman ah interesting. We use it in notifee. not sure what the alternative would be to use 🙁

However, either way, the ts definition file is wrong, even if it's for internal use only. This change doesn't change how EventEmitter is exposed.

[NickGerleman]

I think it is an improvement that the type lines up.

For more context, many of the existing types do not line up internal to the public export, as an artifact of the current types being split from a flat file.

I.e. most of the files have it describing the interface as exported by RN, directly re-exported, vs the type being correct internally, and the re-exporting done at a higher layer. But that’s more an unfortunate historical artifact instead of the ideal.

[facebook-github-bot]

@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@javache merged this pull request in 4acef8e.