feat(crashlytics): add custom message ability to javascript stack tra…

…ces (#4609)

* fix: crashlytics custom js error display in firebase ui
* add test
* fix lint

packages/crashlytics/e2e/crashlytics.e2e.js

@@ -112,6 +112,16 @@ describe('crashlytics()', () => {
       firebase.crashlytics().recordError(new Error("I'm a teapot!"));
       // TODO verify stack obj
     });
+
+    it('accepts optional jsErrorName', async () => {
+      firebase
+        .crashlytics()
+        .recordError(
+          new Error("I'm a teapot!"),
+          'This message will display in crashlytics dashboard',
+        );
+      // TODO verify stack obj
+    });
   });
 
   describe('sendUnsentReports()', () => {

packages/crashlytics/lib/handlers.js

@@ -19,13 +19,25 @@ import { isError, once } from '@react-native-firebase/app/lib/common';
 import tracking from 'promise/setimmediate/rejection-tracking';
 import StackTrace from 'stacktrace-js';
 
-export function createNativeErrorObj(error, stackFrames, isUnhandledRejection) {
+export function createNativeErrorObj(error, stackFrames, isUnhandledRejection, jsErrorName) {
   const nativeObj = {};
 
   nativeObj.message = `${error.message}`;
   nativeObj.isUnhandledRejection = isUnhandledRejection;
 
   nativeObj.frames = [];
+
+  if (jsErrorName) {
+    // Option to fix crashlytics display and alerting. You can add an error name to the recordError function
+    nativeObj.frames.push({
+      src: '<unknown>',
+      line: 0,
+      col: 0,
+      fn: '<unknown>',
+      file: jsErrorName,
+    });
+  }
+
   for (let i = 0; i < stackFrames.length; i++) {
     const { columnNumber, lineNumber, fileName, functionName, source } = stackFrames[i];
     let fileNameParsed = '<unknown>';

packages/crashlytics/lib/index.d.ts

@@ -166,8 +166,9 @@ export namespace FirebaseCrashlyticsTypes {
      * ```
      *
      * @param error Expects an instance of Error; e.g. classes that extend Error will also be supported.
+     * @param jsErrorName Optional string containing Javascript error name
      */
-    recordError(error: Error): void;
+    recordError(error: Error, jsErrorName?: string): void;
     /**
      * Enqueues any unsent reports on the device to upload to Crashlytics. This method only applies if
      * automatic data collection is disabled.

packages/crashlytics/lib/index.js

@@ -109,10 +109,10 @@ class FirebaseCrashlyticsModule extends FirebaseModule {
     return this.native.setUserId(userId);
   }
 
-  recordError(error) {
+  recordError(error, jsErrorName) {
     if (isError(error)) {
       StackTrace.fromError(error, { offline: true }).then(stackFrames => {
-        this.native.recordError(createNativeErrorObj(error, stackFrames, false));
+        this.native.recordError(createNativeErrorObj(error, stackFrames, false, jsErrorName));
       });
     } else {
       console.warn(