-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(crashlytics): add custom message ability to javascript stack traces #4609
feat(crashlytics): add custom message ability to javascript stack traces #4609
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/invertase/react-native-firebase/jnvlkl4z0 [Deployment for c691a8e failed] |
Codecov Report
@@ Coverage Diff @@
## master #4609 +/- ##
==========================================
- Coverage 85.42% 85.32% -0.09%
==========================================
Files 109 109
Lines 3710 3712 +2
Branches 346 347 +1
==========================================
- Hits 3169 3167 -2
- Misses 476 479 +3
- Partials 65 66 +1 |
Cool! It is sad to see the bundle line numbers and character numbers ;-) This seems fine, just need to figure out a couple CI checks
Holding off on approval until I know more on the typedoc problem - reasonably sure it's unrelated though, this all looks fine as I read the diffs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, LGTM - thanks!
I am always open to "reasonable" PRs (where yes "reasonable" is fuzzy, but in general I mean as, maintains compatibility with firebase-js-sdk APIs, is not a breaking change, is well tested and documented, helps dev etc. This is an area that is kind of specific to us as we have react-native specific issues with stacks because of bundling, so I'm open to developer experience help in this area |
Description
record custom error
.index.bundle:123192038123:1239810238
Related issues
[v6] Sourcemaps support in Crashlytics dashboard #2327
Find error code line in crashlytics #1783
Release Summary
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter