test: fix test-net-dns-custom-lookup test assertion #1531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanlucas
added
dns
evanlucas
force-pushed
the
fix-dns-custom-tests
branch
2 times, most recently
from
b70703e to
99cb989
Compare
|
I'd rather put |
I'd rather not because it seems to be the norm for it not to be there for Ubuntu and CentOS/RHEL 7 and we need these tests to run on machines other than the build machines without needing to know something like this. |
|
Seems like |
| @@ -12,14 +18,16 @@ function check(addressType, cb) { | |||
| }); | |||
|
|
|||
| var address = addressType === 4 ? '127.0.0.1' : '::1'; | |||
| var host = addressType === 4 ? 'localhost' : 'ip6-localhost'; | |||
There was a problem hiding this comment.
This needs to support both localhost and ip6-localhost for 6-type families.
evanlucas
force-pushed
the
fix-dns-custom-tests
branch
2 times, most recently
from
466ba1e to
ef6480d
Compare
|
CI: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/620/ Modifications were made to manually specify the IP in the custom lookup function. CI seems to like it now. |
|
so many failures .. what's going on with our tests!? |
|
From just looking at the CI results, it looks like some tests are hanging up. Not really sure why yet. |
|
@evanlucas we're cancelling builds and restarting Jenkins. |
|
lgtm @evanlucas see https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/630/ && #1544, merge this baby and we'll get this sorted out |
The assertion made an assumption that the IPv6 address would always be `::1`. Since the address can be different on different platforms, it has been changed to allow multiple addresses. Fixes: nodejs#1527 PR-URL: nodejs#1531 Reviewed-By: Rod Vagg <rod@vagg.org>
evanlucas
force-pushed
the
fix-dns-custom-tests
branch
from
ef6480d to
bfae823
Compare
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 7, 2017
Use fixtures.readKey() rather than common.fixturesDir in test-regress-nodejsGH-1531. PR-URL: nodejs#16811 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
cjihrig
pushed a commit
to cjihrig/node
that referenced
this pull request
Nov 7, 2017
Use fixtures.readKey() rather than common.fixturesDir in test-regress-nodejsGH-1531. PR-URL: nodejs#16811 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
8 tasks
ryzokuken
added a commit
to ryzokuken/node
that referenced
this pull request
Mar 7, 2018
Rename the test appropriately alongside mentioning the subsystem Also, make a few basic changes to make sure the test conforms to the standard test structure Refs: nodejs#19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure
6 tasks
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 11, 2018
Rename the tests appropriately alongside mentioning the subsystem. Also, make a few basic changes to make sure the test conforms to the standard test structure. This renames: - test-regress-nodejsGH-1531 - test-regress-nodejsGH-2245 - test-regress-nodejsGH-3238 - test-regress-nodejsGH-3542 - test-regress-nodejsGH-3739 - test-regress-nodejsGH-4256 PR-URL: nodejs#19212 Refs: nodejs#19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Mar 17, 2018
Rename the tests appropriately alongside mentioning the subsystem. Also, make a few basic changes to make sure the test conforms to the standard test structure. This renames: - test-regress-GH-1531 - test-regress-GH-2245 - test-regress-GH-3238 - test-regress-GH-3542 - test-regress-GH-3739 - test-regress-GH-4256 PR-URL: #19212 Refs: #19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 20, 2018
Rename the tests appropriately alongside mentioning the subsystem. Also, make a few basic changes to make sure the test conforms to the standard test structure. This renames: - test-regress-GH-1531 - test-regress-GH-2245 - test-regress-GH-3238 - test-regress-GH-3542 - test-regress-GH-3739 - test-regress-GH-4256 PR-URL: #19212 Refs: #19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
Rename the tests appropriately alongside mentioning the subsystem. Also, make a few basic changes to make sure the test conforms to the standard test structure. This renames: - test-regress-nodejsGH-1531 - test-regress-nodejsGH-2245 - test-regress-nodejsGH-3238 - test-regress-nodejsGH-3542 - test-regress-nodejsGH-3739 - test-regress-nodejsGH-4256 PR-URL: nodejs#19212 Refs: nodejs#19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Oct 2, 2018
Rename the tests appropriately alongside mentioning the subsystem. Also, make a few basic changes to make sure the test conforms to the standard test structure. This renames: - test-regress-GH-1531 - test-regress-GH-2245 - test-regress-GH-3238 - test-regress-GH-3542 - test-regress-GH-3739 - test-regress-GH-4256 PR-URL: #19212 Refs: #19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The assertion made an assumption that the IPv6 address would always be
::1. Since the address can be different on different platforms, ithas been changed to allow multiple addresses.
Ref: #1527