Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix test-net-dns-custom-lookup test assertion #1531

Merged
merged 1 commit into from
Apr 28, 2015

Conversation

evanlucas
Copy link
Contributor

The assertion made an assumption that the IPv6 address would always be
::1. Since the address can be different on different platforms, it
has been changed to allow multiple addresses.

Ref: #1527

@evanlucas evanlucas added dns Issues and PRs related to the dns subsystem. net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests. labels Apr 26, 2015
@evanlucas evanlucas force-pushed the fix-dns-custom-tests branch 2 times, most recently from b70703e to 99cb989 Compare April 27, 2015 02:14
@jbergstroem
Copy link
Member

I'd rather put ::1 localhost in /etc/hosts.

@rvagg
Copy link
Member

rvagg commented Apr 27, 2015

I'd rather put ::1 localhost in /etc/hosts.

I'd rather not because it seems to be the norm for it not to be there for Ubuntu and CentOS/RHEL 7 and we need these tests to run on machines other than the build machines without needing to know something like this.

@jbergstroem
Copy link
Member

Seems like ip6-localhost needs to go in after all (based on this list).

@@ -12,14 +18,16 @@ function check(addressType, cb) {
});

var address = addressType === 4 ? '127.0.0.1' : '::1';
var host = addressType === 4 ? 'localhost' : 'ip6-localhost';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to support both localhost and ip6-localhost for 6-type families.

@evanlucas evanlucas force-pushed the fix-dns-custom-tests branch 2 times, most recently from 466ba1e to ef6480d Compare April 27, 2015 15:01
@evanlucas
Copy link
Contributor Author

CI: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/620/

Modifications were made to manually specify the IP in the custom lookup function. CI seems to like it now.

@rvagg
Copy link
Member

rvagg commented Apr 28, 2015

so many failures .. what's going on with our tests!?

@evanlucas
Copy link
Contributor Author

From just looking at the CI results, it looks like some tests are hanging up. Not really sure why yet.

@jbergstroem
Copy link
Member

@evanlucas we're cancelling builds and restarting Jenkins.

@rvagg
Copy link
Member

rvagg commented Apr 28, 2015

lgtm @evanlucas see https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/630/ && #1544, merge this baby and we'll get this sorted out

The assertion made an assumption that the IPv6 address would always be
`::1`. Since the address can be different on different platforms, it
has been changed to allow multiple addresses.

Fixes: nodejs#1527
PR-URL: nodejs#1531
Reviewed-By: Rod Vagg <rod@vagg.org>
@evanlucas evanlucas closed this Apr 28, 2015
@evanlucas evanlucas deleted the fix-dns-custom-tests branch April 28, 2015 06:03
@evanlucas evanlucas merged commit bfae823 into nodejs:master Apr 28, 2015
@rvagg rvagg mentioned this pull request Apr 28, 2015
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 7, 2017
Use fixtures.readKey() rather than common.fixturesDir in
test-regress-nodejsGH-1531.

PR-URL: nodejs#16811
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
cjihrig pushed a commit to cjihrig/node that referenced this pull request Nov 7, 2017
Use fixtures.readKey() rather than common.fixturesDir in
test-regress-nodejsGH-1531.

PR-URL: nodejs#16811
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
Use fixtures.readKey() rather than common.fixturesDir in
test-regress-GH-1531.

PR-URL: #16811
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
Use fixtures.readKey() rather than common.fixturesDir in
test-regress-GH-1531.

PR-URL: #16811
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
Use fixtures.readKey() rather than common.fixturesDir in
test-regress-GH-1531.

PR-URL: #16811
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
Use fixtures.readKey() rather than common.fixturesDir in
test-regress-GH-1531.

PR-URL: #16811
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
ryzokuken added a commit to ryzokuken/node that referenced this pull request Mar 7, 2018
Rename the test appropriately alongside mentioning the subsystem
Also, make a few basic changes to make sure the test conforms
to the standard test structure

Refs: nodejs#19105
Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 11, 2018
Rename the tests appropriately alongside mentioning the subsystem.
Also, make a few basic changes to make sure the test conforms
to the standard test structure.

This renames:
- test-regress-nodejsGH-1531
- test-regress-nodejsGH-2245
- test-regress-nodejsGH-3238
- test-regress-nodejsGH-3542
- test-regress-nodejsGH-3739
- test-regress-nodejsGH-4256

PR-URL: nodejs#19212
Refs: nodejs#19105
Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Mar 17, 2018
Rename the tests appropriately alongside mentioning the subsystem.
Also, make a few basic changes to make sure the test conforms
to the standard test structure.

This renames:
- test-regress-GH-1531
- test-regress-GH-2245
- test-regress-GH-3238
- test-regress-GH-3542
- test-regress-GH-3739
- test-regress-GH-4256

PR-URL: #19212
Refs: #19105
Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
Rename the tests appropriately alongside mentioning the subsystem.
Also, make a few basic changes to make sure the test conforms
to the standard test structure.

This renames:
- test-regress-GH-1531
- test-regress-GH-2245
- test-regress-GH-3238
- test-regress-GH-3542
- test-regress-GH-3739
- test-regress-GH-4256

PR-URL: #19212
Refs: #19105
Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
Rename the tests appropriately alongside mentioning the subsystem.
Also, make a few basic changes to make sure the test conforms
to the standard test structure.

This renames:
- test-regress-nodejsGH-1531
- test-regress-nodejsGH-2245
- test-regress-nodejsGH-3238
- test-regress-nodejsGH-3542
- test-regress-nodejsGH-3739
- test-regress-nodejsGH-4256

PR-URL: nodejs#19212
Refs: nodejs#19105
Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit that referenced this pull request Oct 2, 2018
Rename the tests appropriately alongside mentioning the subsystem.
Also, make a few basic changes to make sure the test conforms
to the standard test structure.

This renames:
- test-regress-GH-1531
- test-regress-GH-2245
- test-regress-GH-3238
- test-regress-GH-3542
- test-regress-GH-3739
- test-regress-GH-4256

PR-URL: #19212
Refs: #19105
Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dns Issues and PRs related to the dns subsystem. net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants