test: update test to use fixtures.readKey #16811
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
approved these changes
Nov 6, 2017
| @@ -1,16 +1,19 @@ | |||
| 'use strict'; | |||
| const common = require('../common'); | |||
|
|
|||
| // This test ensures that a http request callback is called | |||
| // when the agent option is set. See https://github.com/nodejs/node-v0.x-archive/issues/1531 | |||
There was a problem hiding this comment.
Would you mind moving the See ... to a new line to stay under 80 characters.
apapirovski
approved these changes
Nov 6, 2017
gireeshpunathil
added
the
code-and-learn
gireeshpunathil
approved these changes
Nov 6, 2017
Trott
approved these changes
Nov 7, 2017
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 7, 2017
Use fixtures.readKey() rather than common.fixturesDir in test-regress-nodejsGH-1531. PR-URL: nodejs#16811 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
|
Landed in 207b24a. |
cjihrig
pushed a commit
to cjihrig/node
that referenced
this pull request
Nov 7, 2017
Use fixtures.readKey() rather than common.fixturesDir in test-regress-nodejsGH-1531. PR-URL: nodejs#16811 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test:
test/parallel/test-regress-GH-1531.js