-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: item-sliding, options don't display correctly in RTL mode on Firefox or Safari #26103
Comments
I was also able to reproduce this on LTR. |
@DwieDima Do you have a Github repo I could look at? Checking in core again, I'm still only able to reproduce in RTL. |
@amandaejohnston we have this issue in our project, which i cannot share, but i'll try to setup a reproduction repo asap! |
@amandaejohnston is was able to reproduce this behavior, and found another issue, too: Bug where options won't show properly:
Bug where slides won't lock into position, instead close immediately:
https://stackblitz.com/edit/angular-bo8fxh?file=src/app/example.component.html Bildschirmaufnahme.2022-11-18.um.10.40.09.movEDITIssue "Bug where options won't show properly" can be fixed using parts: ion-item-option::part(native) {
width: 80px;
} Issue "Bug where slides won't lock into position, instead close immediately" can be fixed using single nevertheless, the question would be whether this behavior is intended in this way. |
Issue URL: resolves #26103, resolves #25285 --------- <!-- Please refer to our contributing documentation for any questions on submitting a pull request, or let us know here if you need any help: https://ionicframework.com/docs/building/contributing --> <!-- Some docs updates need to be made in the `ionic-docs` repo, in a separate PR. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#modifying-documentation for details. --> <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Options in `item-sliding` will not display when using RTL with Firefox and Safari. <!-- Issues are required for both bug fixes and features. --> ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> Issue was coming from `:host-context`. Firefox would keep [removing the entire](https://www.w3.org/TR/selectors-3/#grouping) compiled style when using this unsupported style. This would led to the RTL styles to not being applied to the component. - Split the CSS group from `add-root-selector()` - Added comments to make it easier to navigate through `add-root-selector()` - Added `:dir()` ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Co-authored-by: brandyscarney <brandyscarney@users.noreply.github.com> - Updating `add-root-selector()` would also fix another [issue](#25285) unintentionally --------- Co-authored-by: ionitron <hi@ionicframework.com> Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
The fix has been applied through PR #27203. |
The fix has been released in v7.0.6. |
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out. |
Prerequisites
Ionic Framework Version
Current Behavior
In core, a basic
ion-item-sliding
will not show its options properly when opened in Firefox or Safari in RTL mode. Interestingly, using theexpandable
prop causes the options to display somewhat when dragging far enough, but the text is positioned incorrectly.Screencast from Firefox: https://user-images.githubusercontent.com/90629384/195179136-fda916dd-14ad-4b30-a5f4-3e801ac9f2c9.mp4
Expected Behavior
Screencast from Chrome: https://user-images.githubusercontent.com/90629384/195179307-1a31d302-7764-46c4-89e9-406097630444.mp4
Steps to Reproduce
Host core locally and open http://localhost:3333/src/components/item-sliding/test/basic?rtl=true in Firefox or Safari, then drag any item open.
Code Reproduction URL
http://localhost:3333/src/components/item-sliding/test/basic?rtl=true
Ionic Info
Additional Information
No response
The text was updated successfully, but these errors were encountered: