Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Modal and Popover is missing focusTrap option in Angular #29728

Closed
3 tasks done
hakimio opened this issue Jul 22, 2024 · 1 comment · Fixed by #29729 · 4 remaining pull requests
Closed
3 tasks done

bug: Modal and Popover is missing focusTrap option in Angular #29728

hakimio opened this issue Jul 22, 2024 · 1 comment · Fixed by #29729 · 4 remaining pull requests
Labels
package: angular @ionic/angular package type: bug a confirmed bug report

Comments

@hakimio
Copy link

hakimio commented Jul 22, 2024

Prerequisites

Ionic Framework Version

v8.x

Current Behavior

Angular popover component is missing focusTrap input.

Expected Behavior

Following code should work:

<ion-popover
    [focusTrap]="false"
/>

Steps to Reproduce

  1. Try to set focusTrap input on ion-popover component.

Code Reproduction URL

https://github.com/ionic-team/ionic-framework/

Ionic Info

@ionic/angular: 8.2.4

Additional Information

@liamdebeasi
#29379

@ionitron-bot ionitron-bot bot added the triage label Jul 22, 2024
@sean-perkins sean-perkins changed the title bug: Angular popover is missing focusTrap option bug: Modal and Popover is missing focusTrap option in Angular Jul 22, 2024
@sean-perkins sean-perkins added package: angular @ionic/angular package type: bug a confirmed bug report labels Jul 22, 2024
@ionitron-bot ionitron-bot bot removed the triage label Jul 22, 2024
github-merge-queue bot pushed a commit that referenced this issue Jul 24, 2024
Issue number: resolves #29728

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

The `focusTrap` property was missed when adding focus trapping
configuration to the modal and popover. This results in a type error
when developers attempt to assign to the property.

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- Adds `focusTrap` property to `ion-modal` and `ion-popover` for the
angular component wrappers
- Resolves type warnings when using the property in angular

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!--
  If this introduces a breaking change:
1. Describe the impact and migration path for existing applications
below.
  2. Update the BREAKING.md file with the breaking change.
3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
See
https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer
for more information.
-->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->

Dev-build: `8.2.6-dev.11721672792.195afb09`
Copy link

ionitron-bot bot commented Aug 23, 2024

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.