feat(modal, popover): add ability to temporarily disable focus trapping #29379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
liamdebeasi
changed the title
liamdebeasi
requested review from
averyjohnston
and removed request for
averyjohnston
thetaPC
approved these changes
Apr 24, 2024
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
6 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #24646
What is the current behavior?
Ionic's focus trapping ensures that focus does not move outside of overlays. However, it only recognizes Ionic overlays (
ion-modal,ion-popover, etc) as valid overlays. This means presenting a 3rd party overlay from an Ionic overlay is challenging to do because focus never moves to the 3rd party overlay. Developers have requested more control over the focus trapping behavior so they can use 3rd party overlays. By giving developers more control over when focus trapping applies, they will be able to ensure that focus can move from an Ionic overlay to a 3rd party overlay.What is the new behavior?
Does this introduce a breaking change?
Other information
Dev build:
8.0.0-dev.11712850753.10c4a960