Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(many): remove redundant :host selector from styles #26383

Closed
wants to merge 15 commits into from

Conversation

sean-perkins
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Components using the shadow DOM do not need to specify :host when targeting a child selector. ion-datetime, ion-datetime-button, ion-picker-internal and ion-picker-column-internal have redundant usage of :host .element-selector.

Issue URL: Relates to #25285

What is the new behavior?

  • Removes the :host selector in usages that target an explicit child selector in ion-datetime, ion-datetime-button, ion-picker-internal and ion-picker-column-internal

Does this introduce a breaking change?

  • Yes
  • No

Other information

This PR blocks #25264

@github-actions github-actions bot added the package: core @ionic/core package label Nov 30, 2022
@sean-perkins sean-perkins marked this pull request as ready for review November 30, 2022 17:23
@sean-perkins sean-perkins requested a review from a team as a code owner November 30, 2022 17:23
@liamdebeasi
Copy link
Contributor

Noticing some diffs:
image

The calendar body diffs are fine (font changes from a previous fix that was not caught). But it looks like the arrow is misaligned.

@sean-perkins
Copy link
Contributor Author

I'll run the update reference screenshot job against this branch to see if I can get the diffs to come through on CI as well. I'll obviously hold on merging until we can identify the cause.

It is odd that just the removal of :host on the diff styles would cause any visual changes. It is possible that one of our mixins (e.g. the one identified in the open community PR) is producing incorrect output when the incoming selector doesn't explicitly contain :host.

@sean-perkins sean-perkins removed the request for review from averyjohnston December 19, 2022 17:37
Copy link
Contributor

@averyjohnston averyjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still seeing the chevron misalignment Liam pointed out in his earlier comment, at least in the screenshot updates.

Edit: Ah, just saw you removed the request for review while I had this tab open from earlier; disregard 😆

@liamdebeasi
Copy link
Contributor

@sean-perkins Do we still want to merge this?

@liamdebeasi
Copy link
Contributor

liamdebeasi commented Mar 13, 2023

We are going to investigate this issue again in an upcoming sprint as much of the code for impacted datetime has changed.

@sean-perkins sean-perkins deleted the chore/remove-host-selector-shadow-styles branch March 24, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants