-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(many): remove redundant :host selector from styles #26383
Conversation
I'll run the update reference screenshot job against this branch to see if I can get the diffs to come through on CI as well. I'll obviously hold on merging until we can identify the cause. It is odd that just the removal of |
This reverts commit aa6b552.
…ector-shadow-styles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still seeing the chevron misalignment Liam pointed out in his earlier comment, at least in the screenshot updates.
Edit: Ah, just saw you removed the request for review while I had this tab open from earlier; disregard 😆
@sean-perkins Do we still want to merge this? |
We are going to investigate this issue again in an upcoming sprint as much of the code for impacted datetime has changed. |
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docs
repo, in a separate PR. See the contributing guide for details.npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Components using the shadow DOM do not need to specify
:host
when targeting a child selector.ion-datetime
,ion-datetime-button
,ion-picker-internal
andion-picker-column-internal
have redundant usage of:host .element-selector
.Issue URL: Relates to #25285
What is the new behavior?
:host
selector in usages that target an explicit child selector inion-datetime
,ion-datetime-button
,ion-picker-internal
andion-picker-column-internal
Does this introduce a breaking change?
Other information
This PR blocks #25264