-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(css): rtl mixin preserves selectors after :host #25264
Conversation
Ie: :host .element-selector when using rtl was translated as :host-context([dir=rtl]) instead of :host-context([dir=rtl]) .element-selector
Thanks for the PR! We require that any fix/feature PRs to be associated with an existing issue prior to merging. Is there an open issue that we can link this to? Having an issue with steps to reproduce helps us better verify the proposed fix. |
Thanks I've opened: #25285 |
Thanks! There are several components that make use of the For example this line in datetime probably does not need the position mixin: https://github.com/ionic-team/ionic-framework/blob/main/core/src/components/datetime/datetime.scss#L346 However, the change in this PR breaks its positioning: We will schedule some time in an upcoming sprint to scrutinize which components need updates and make the appropriate changes. |
Release 6.3.8
resolves ionic-team#21182 Co-authored-by: dan-rp1 <dan-rp1@users.noreply.github.com>
resolves ionic-team#19178, resolves ionic-team#17168 Co-authored-by: Mathieu-COSYNS <Mathieu-COSYNS@users.noreply.github.com>
Ignore the large file diff for now (getting things ready for team review/merge into 6.4). Once I sync 6.4 with main the diff will be the single file change. |
Ie: :host .element-selector when using rtl was translated as :host-context([dir=rtl]) instead of :host-context([dir=rtl]) .element-selector
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
With the following CSS:
When using the rtl mixin so, also add-root-selector it translates the selector as:
So part of it is lost.
Issue URL: #25285
What is the new behavior?
With the following CSS:
When using the rtl mixin so, also add-root-selector it translates the selector as:
Maintaining the whole selector.
Does this introduce a breaking change?
Other information