Merge pull request #10 from Kub4jz/unsubscribe

Add unsubscribe callback as return type of mapStateToProps
ionic-team · Nov 1, 2018 · f2b76cf · f2b76cf
2 parents 95b9c78 + b7dcfbe
commit f2b76cf
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -69,9 +69,11 @@ export class MyComponent {
   @State() name: string;
 
   changeName: Action;
-
+
+  private unsubscribe: () => void;
+
   componentWillLoad() {
-    this.store.mapStateToProps(this, (state) => {
+    this.unsubscribe = this.store.mapStateToProps(this, (state) => {
       const {
         myReducer: { name }
       } = state;
@@ -88,5 +90,9 @@ export class MyComponent {
   doNameChange(newName: string) {
     this.changeName(newName);
   }
+
+  componentDidUnload() {
+    this.unsubscribe();
+  }
 }
 ```
diff --git a/src/global/interfaces.ts b/src/global/interfaces.ts
@@ -4,7 +4,7 @@ export interface Store {
   getState: () => any;
   getStore: () => any;
   setStore: (any: any) => void;
-  mapStateToProps: (component: any, props: any) => void;
+  mapStateToProps: (component: any, props: any) => () => void;
   mapDispatchToProps: (component: any, props: any) => void;
 };
 

diff --git a/src/global/store.ts b/src/global/store.ts
@@ -39,9 +39,11 @@ Context.store = (function() {
       });
     };
 
-    _store.subscribe(() => _mapStateToProps(component, mapState));
+    const unsubscribe = _store.subscribe(() => _mapStateToProps(component, mapState));
 
     _mapStateToProps(component, mapState);
+
+    return unsubscribe;
   }
 
   return {