Skip to content
This repository has been archived by the owner on Jul 28, 2022. It is now read-only.

Add unsubscribe callback as return type of mapStateToProps #10

Merged
merged 2 commits into from
Nov 1, 2018
Merged

Add unsubscribe callback as return type of mapStateToProps #10

merged 2 commits into from
Nov 1, 2018

Conversation

Kub4jz
Copy link

@Kub4jz Kub4jz commented Oct 31, 2018

Useful when used with router. Subscriptions have to be unsubscribed to prevent memory leaks.

@mlynch mlynch merged commit f2b76cf into ionic-team:master Nov 1, 2018
@mlynch
Copy link
Contributor

mlynch commented Nov 1, 2018

awesome thanks. I think we will want to eventually automate this specific operation so it Just Works, but this is a good solution for now!

@Kub4jz Kub4jz deleted the unsubscribe branch November 1, 2018 16:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants