Skip to content

Commit

Permalink
Remove dependency on identity_core default features (#1408)
Browse files Browse the repository at this point in the history
* Remove dependency on `identity_core` default features

`identity_did` and `identity_document` depend on `identity_core` but do
not turn off default features. This means that these crates cannot be
compiled for `wasm32-unknown-unknown` without a dependency on `js-sys`.

Given the default features are not required, removing them makes these
crates compatible across a wider range of compilation targets.

* chore: enable default feature for identity core

* chore: fmt

---------

Co-authored-by: Yasir <yasir@shariff.dev>
  • Loading branch information
Frederik Rothenberger and itsyaasir authored Sep 13, 2024
1 parent a0c7b06 commit 13acb23
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion identity_did/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ description = "Agnostic implementation of the Decentralized Identifiers (DID) st
[dependencies]
did_url_parser = { version = "0.2.0", features = ["std", "serde"] }
form_urlencoded = { version = "1.2.0", default-features = false, features = ["alloc"] }
identity_core = { version = "=1.3.1", path = "../identity_core" }
identity_core = { version = "=1.3.1", path = "../identity_core", default-features = false }
identity_jose = { version = "=1.3.1", path = "../identity_jose" }
serde.workspace = true
strum.workspace = true
Expand Down
2 changes: 1 addition & 1 deletion identity_document/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ description = "Method-agnostic implementation of the Decentralized Identifiers (

[dependencies]
did_url_parser = { version = "0.2.0", features = ["std", "serde"] }
identity_core = { version = "=1.3.1", path = "../identity_core" }
identity_core = { version = "=1.3.1", path = "../identity_core", default-features = false }
identity_did = { version = "=1.3.1", path = "../identity_did" }
identity_verification = { version = "=1.3.1", path = "../identity_verification", default-features = false }
indexmap = { version = "2.0", default-features = false, features = ["std", "serde"] }
Expand Down
2 changes: 1 addition & 1 deletion identity_jose/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ description = "A library for JOSE (JSON Object Signing and Encryption)"

[dependencies]
bls12_381_plus.workspace = true
identity_core = { version = "=1.3.1", path = "../identity_core", default-features = false }
identity_core = { version = "=1.3.1", path = "../identity_core" }
iota-crypto = { version = "0.23.2", default-features = false, features = ["std", "sha"] }
json-proof-token.workspace = true
serde.workspace = true
Expand Down
2 changes: 1 addition & 1 deletion identity_verification/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ rust-version.workspace = true
description = "Verification data types and functionality for identity.rs"

[dependencies]
identity_core = { version = "=1.3.1", path = "./../identity_core", default-features = false }
identity_core = { version = "=1.3.1", path = "./../identity_core" }
identity_did = { version = "=1.3.1", path = "./../identity_did", default-features = false }
identity_jose = { version = "=1.3.1", path = "./../identity_jose", default-features = false }
serde.workspace = true
Expand Down

0 comments on commit 13acb23

Please sign in to comment.