-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on identity_core
default features
#1408
Remove dependency on identity_core
default features
#1408
Conversation
`identity_did` and `identity_document` depend on `identity_core` but do not turn off default features. This means that these crates cannot be compiled for `wasm32-unknown-unknown` without a dependency on `js-sys`. Given the default features are not required, removing them makes these crates compatible across a wider range of compilation targets.
@itsyaasir: I ran into another issue related to |
Hello! Thanks for doing this, I think this should be fine. |
@frederikrothenberger can you make sure everything is working well on your side before we merge this in ? Thanks |
@itsyaasir: There are other features that we need (e.g. #1406) but in terms of compiling the library (at least the crates that we currently use) such that it works on the ICP platform, I can confirm that it works. Thanks. |
@itsyaasir: Could this be merged? |
Description of change
identity_did
andidentity_document
depend onidentity_core
but do not turn off default features. This means that these crates cannot be compiled forwasm32-unknown-unknown
without a dependency onjs-sys
.Given the default features are not required, removing them makes these crates compatible across a wider range of compilation targets.
Type of change
Add an
x
to the boxes that are relevant to your changes.How the change has been tested
Existing test suite.
Change checklist
Add an
x
to the boxes that are relevant to your changes.