Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This removes the
lintPtrNullWithoutFree(content)
function which is used when building the Wasm/TS/JS bindings.The lint was introduced to catch generated code that nulls out Wasm pointers without de-registering the finalizer (we build our bindings with the
--weak-refs
flag for automatic garbage collection see this section of the wasm-bindgen reference).As of wasm-bindgen PR #3117 which is included in version
0.2.84
ofwasm-bindgen
such problematic code is no longer generated hence the lint is no longer needed.How the change has been tested
Tested building this code (in
wasm_core_did.rs
)with
wasm-bindgen
version0.2.83
and0.2.84
. In the former the lint is triggered by all three of those functions, while in version0.2.84
the lint passes.Change checklist
Add an
x
to the boxes that are relevant to your changes.