-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update identity 0.6 to Stronghold 2.0 #1174
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippGackstatter
added
Wasm
Related to Wasm bindings. Becomes part of the Wasm changelog
Chore
Tedious, typically non-functional change
Rust
Related to the core Rust code. Becomes part of the Rust changelog.
labels
May 24, 2023
PhilippGackstatter
added
the
Patch
Change without affecting the API that requires a patch release. Part of "Patch" section in changelog
label
May 24, 2023
eike-hass
approved these changes
May 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Merged blocked until we have a Stronghold 2.0 final though.
abdulmth
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Upgrade stronghold to
2.0
.Cargo.lock
in stronghold-nodejs which is necessary for a successful build of those bindings.support/v0.6
, analogously to what was done in Remove outdated lint #1111.Links to any relevant issues
Be sure to reference any related issues by adding
fixes issue #
.Type of change
Add an
x
to the boxes that are relevant to your changes.How the change has been tested
This PR was tested by running the
account_create
on the currentsupport/v0.6
. The resulting stronghold snapshot was then used as input for migrating the snapshot from v2 to v3 using themigrate_stronghold_snapshot_v2_to_v3
example (and using"identity.rs"
as the salt) from iota-sdk (currently on iotaledger/iota-sdk#456).Then the
account_create_vc
example was modified to load the existing DID and the v3 snapshot using the code from this PR and signing with the existing method whose key is in the stronghold. The example ran successfully.It was also tested that an upate to an identity can be performed, signed by a key in the migrated stronghold, published and successfully resolved.
Change checklist
Add an
x
to the boxes that are relevant to your changes.