-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support v0.4: Pin iota-crypto versions #829
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivereanderson
added
Bug
Something isn't working.
Patch
Change without affecting the API that requires a patch release. Part of "Patch" section in changelog
labels
May 2, 2022
eike-hass
added
Rust
Related to the core Rust code. Becomes part of the Rust changelog.
and removed
Bug
Something isn't working.
labels
May 3, 2022
10 tasks
olivereanderson
changed the title
Pin iota-crypto versions
Support v0.4: Pin iota-crypto versions
May 3, 2022
It might be better for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The release of
iota-crypto
version0.9.2
introduced a breaking change by bumping theirbee-ternary
dependency to version0.6.0
which then breaks compilation ofbee-pow: 0.2.0
imported byiota-client
(see iotaledger/bee#1360 for a better description).This PR pins dependencies on
iota-crypto
(and updates the dependency oniota-client
) thus making it possible to buildidentity: ^0.4
without the need for library consumers to adjust their dependencies oniota-crypto
(and other breaking crates) in theirCargo.lock
file. Note that a fix for thedev
branch was merged in #822.Open questions
>=0.7, <= 0.9.1
for theiota-crypto
dependency inidentity-iota
leads toiota-crypto: 0.9.2
being pulled. It seems likebee-message
pulls0.9.2
instead of using0.9.1
unless at least one of our crates has a strict equalityiota-crypto version =0.9.1
. It seems like Cargo is not smart enough to re-use0.9.1
when given enough freedom. As a somewhat hacky workaround I simply pinned the version to=0.9.1
inidentity-iota
which did lead to a correct build. Is this OK?iota-client
dependency could not continue using the pinned git hash without breaking builds, but it works now using version^1.1.1
published on crates.io. Is this OK?Links to any relevant issues
Be sure to reference any related issues by adding
fixes issue #
.Type of change
Add an
x
to the boxes that are relevant to your changes.How the change has been tested
Several builds have been successfully built and tested locally and in the CI.
Change checklist
Add an
x
to the boxes that are relevant to your changes.