Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin iota-crypto, napi dependencies #822

Merged
merged 2 commits into from
Apr 28, 2022
Merged

Pin iota-crypto, napi dependencies #822

merged 2 commits into from
Apr 28, 2022

Conversation

cycraig
Copy link
Contributor

@cycraig cycraig commented Apr 26, 2022

Description of change

Pin the iota-crypto dependency to 0.9.1 to fix compilation errors related to bee-pow 0.2.0.

Unfortunately we'll be stuck on this version for a while, so we may have to deal with not being able to pull in requested features from iota-crypto when they're released, such as the aes-cbc feature.

Also pins napi dependencies to 2.2.0 to fix a TypeScript error in the later 2.3.3 version. Commits the Cargo.lock file for the Stronghold bindings to mitigate problems in the future.

Links to any relevant issues

Type of change

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

All crates compile and pass tests locally, including the Wasm bindings.

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@cycraig cycraig added Wasm Related to Wasm bindings. Becomes part of the Wasm changelog No changelog Excludes PR from becoming part of any changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. labels Apr 26, 2022
@cycraig cycraig changed the title Pin iota-crypto to 0.9.1 to fix compilation Pin iota-crypto, napi dependencies Apr 27, 2022
napi = { version = "=2.2.0", default-features = false, features = ["napi4", "tokio_rt", "serde-json"] }
napi-build = { version = "=1.2.1" }
napi-derive = { version = "=2.2.0" }
napi-derive-backend = { version = "=1.0.26" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need napi-build and napi-derive-backend?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To pin them to a compatible version for napi-derive to work. Removing them and running cargo update causes compilation errors.

@eike-hass eike-hass self-requested a review April 28, 2022 10:38
@cycraig cycraig merged commit c27c371 into dev Apr 28, 2022
@cycraig cycraig deleted the fix/iota-crypto branch April 28, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No changelog Excludes PR from becoming part of any changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. Wasm Related to Wasm bindings. Becomes part of the Wasm changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants