Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin iota-crypto version #834

Merged
merged 1 commit into from
May 5, 2022
Merged

Conversation

olivereanderson
Copy link
Contributor

@olivereanderson olivereanderson commented May 4, 2022

Description of change

This PR specifies the iota-crypto dependencies used by this library to be in the range 0.7 up to (but NOT including) 0.10. #822 pinned the version to 0.9.1 which was necessary because 0.9.2 introduced a breaking change causing builds to fail. Now 0.9.2 has been yanked from crates.io and pinning is therefore no longer necessary.

Open questions

Before #822, we specified version ^0.7 for iota-crypto in our crates except for libjose (the reason 0.9.2 still got pulled was because of transitive dependencies (which pinning to 0.9.1 then prevented)), but as #822 demonstrated our library also worked with 0.9.1 and I have also tested with 0.8. Hence the question is do we use the range specified in this PR, or go back to ^0.7 or use ^0.9 which is now OK due to 0.9.2 being yanked?

Links to any relevant issues

Be sure to reference any related issues by adding fixes issue #.

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@olivereanderson olivereanderson self-assigned this May 4, 2022
@olivereanderson olivereanderson added Rust Related to the core Rust code. Becomes part of the Rust changelog. No changelog Excludes PR from becoming part of any changelog labels May 4, 2022
@olivereanderson olivereanderson changed the title unpin iota-crypto version Unpin iota-crypto version May 4, 2022
Copy link
Contributor

@cycraig cycraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, a version range is definitely the way this was meant to be done, rather than pinning.

Although we should probably stay with the latest version possible for security updates etc., I don't see any changes since 0.7.0 that should affect us, so the range is probably fine?

@olivereanderson olivereanderson merged commit 61b9a2b into dev May 5, 2022
@olivereanderson olivereanderson deleted the chore/unpin-iota-crypto-version branch May 5, 2022 12:40
@eike-hass eike-hass added Patch Change without affecting the API that requires a patch release. Part of "Patch" section in changelog and removed No changelog Excludes PR from becoming part of any changelog labels May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Patch Change without affecting the API that requires a patch release. Part of "Patch" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants