[staking] only validate duplicate candidate id after HF (#4318)

iotexproject · Jul 1, 2024 · 80717a7 · 80717a7
1 parent 7378cdf
commit 80717a7
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/action/protocol/staking/handlers.go b/action/protocol/staking/handlers.go
@@ -699,12 +699,11 @@ func (p *Protocol) handleCandidateRegister(ctx context.Context, act *action.Cand
 			}
 		}
 		candID = id
-	}
-	c = csm.GetByIdentifier(candID)
-	if c != nil {
-		return log, nil, &handleError{
-			err:           ErrInvalidOwner,
-			failureStatus: iotextypes.ReceiptStatus_ErrCandidateAlreadyExist,
+		if csm.GetByIdentifier(candID) != nil {
+			return log, nil, &handleError{
+				err:           ErrInvalidOwner,
+				failureStatus: iotextypes.ReceiptStatus_ErrCandidateAlreadyExist,
+			}
 		}
 	}
 	// cannot collide with existing name