Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[staking] only validate duplicate candidate id after HF #4318

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

envestcc
Copy link
Member

@envestcc envestcc commented Jul 1, 2024

Description

The check for duplicate candidate IDs during registration should be placed after the hard fork, as the ID is introduced only after the hard fork.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [] make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

@envestcc envestcc changed the title [staking] only validatge duplicate candidate id after HF [staking] only validate duplicate candidate id after HF Jul 1, 2024
Copy link

sonarcloud bot commented Jul 1, 2024

@envestcc envestcc merged commit 80717a7 into master Jul 1, 2024
3 checks passed
@envestcc envestcc deleted the fix-candidate-id branch July 1, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants