Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ioctl] Build SendAction unittest #3584

Merged

Conversation

LuckyPigeon
Copy link
Contributor

@LuckyPigeon LuckyPigeon commented Aug 4, 2022

Description

Build SendAction unittest for action command

refer to #3444 & #3472

Type of change

Please delete options that are not relevant.

  • Code refactor or improvement

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • make test
  • TestSendAction

Test Configuration:

  • Firmware version: Ubuntu 21.04
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@LuckyPigeon LuckyPigeon marked this pull request as ready for review August 4, 2022 20:05
@LuckyPigeon LuckyPigeon requested a review from a team as a code owner August 4, 2022 20:05
@LuckyPigeon
Copy link
Contributor Author

This PR seems too big, I'll move the reset unittest into another PR.

@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #3584 (587897b) into master (a20e489) will decrease coverage by 0.92%.
The diff coverage is 73.41%.

❗ Current head 587897b differs from pull request most recent head 3f7549f. Consider uploading reports for the commit 3f7549f to get more accurate results

@@            Coverage Diff             @@
##           master    #3584      +/-   ##
==========================================
- Coverage   75.43%   74.51%   -0.93%     
==========================================
  Files         247      261      +14     
  Lines       22845    23602     +757     
==========================================
+ Hits        17233    17586     +353     
- Misses       4685     5094     +409     
+ Partials      927      922       -5     
Impacted Files Coverage Δ
action/action_deserializer.go 57.14% <ø> (ø)
action/protocol/poll/nativestaking.go 41.08% <0.00%> (-0.65%) ⬇️
action/protocol/poll/staking_command.go 10.71% <0.00%> (ø)
action/protocol/staking/read_state.go 15.38% <0.00%> (ø)
action/protocol/vote/probationlist.go 87.50% <ø> (ø)
api/blocklistener.go 70.73% <0.00%> (ø)
api/websocket.go 5.17% <0.00%> (-0.19%) ⬇️
blockchain/block/block_deserializer.go 71.15% <ø> (ø)
blockchain/blockchain.go 0.89% <0.00%> (ø)
blockchain/filedao/filedao_legacy.go 85.80% <ø> (ø)
... and 109 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

ioctl/newcmd/account/account.go Outdated Show resolved Hide resolved
ioctl/newcmd/action/action.go Outdated Show resolved Hide resolved
ioctl/newcmd/action/action_test.go Outdated Show resolved Hide resolved
ioctl/newcmd/action/action_test.go Outdated Show resolved Hide resolved
ioctl/newcmd/action/action_test.go Outdated Show resolved Hide resolved
ioctl/newcmd/action/action_test.go Outdated Show resolved Hide resolved
ioctl/newcmd/action/action_test.go Outdated Show resolved Hide resolved
ioctl/newcmd/action/action_test.go Outdated Show resolved Hide resolved
ioctl/newcmd/action/action_test.go Outdated Show resolved Hide resolved
ioctl/newcmd/action/action_test.go Outdated Show resolved Hide resolved
ioctl/newcmd/action/action_test.go Outdated Show resolved Hide resolved
ioctl/newcmd/action/action_test.go Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Sep 6, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 3 Code Smells

No Coverage information No Coverage information
3.6% 3.6% Duplication

@huof6829 huof6829 merged commit dea27ac into iotexproject:master Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants