Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ioctl] Build Execution unittest #3631

Merged
merged 21 commits into from
Oct 13, 2022

Conversation

LuckyPigeon
Copy link
Contributor

Description

Build Execute unittest for action command

refer to #3444 & #3472

Type of change

Please delete options that are not relevant.

  • Code refactor or improvement

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • make test
  • TestExecute

Test Configuration:

  • Firmware version: Windows 10 (WSL Version: Ubuntu 18.04)
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@LuckyPigeon LuckyPigeon marked this pull request as ready for review September 7, 2022 16:08
@LuckyPigeon LuckyPigeon requested a review from a team as a code owner September 7, 2022 16:08
@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #3631 (dfaa321) into master (e9732a1) will decrease coverage by 0.14%.
The diff coverage is 83.00%.

❗ Current head dfaa321 differs from pull request most recent head ad84eb4. Consider uploading reports for the commit ad84eb4 to get more accurate results

@@            Coverage Diff             @@
##           master    #3631      +/-   ##
==========================================
- Coverage   74.95%   74.80%   -0.15%     
==========================================
  Files         269      266       -3     
  Lines       23819    23763      -56     
==========================================
- Hits        17854    17777      -77     
- Misses       5039     5061      +22     
+ Partials      926      925       -1     
Impacted Files Coverage Δ
db/config.go 100.00% <ø> (ø)
db/trie/mptrie/node.go 100.00% <ø> (ø)
ioctl/newcmd/action/action.go 89.09% <ø> (+9.55%) ⬆️
ioctl/newcmd/node/nodedelegate.go 70.19% <0.00%> (-0.95%) ⬇️
ioctl/newcmd/node/nodeprobationlist.go 90.90% <0.00%> (-4.33%) ⬇️
action/protocol/execution/evm/evm.go 44.57% <26.66%> (-0.86%) ⬇️
db/trie/mptrie/hashnode.go 36.36% <41.17%> (-54.55%) ⬇️
db/trie/mptrie/merklepatriciatrie.go 78.73% <46.80%> (-12.70%) ⬇️
db/db_bolt.go 72.13% <50.00%> (-0.39%) ⬇️
db/trie/mptrie/leafiterator.go 62.06% <50.00%> (ø)
... and 22 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@huangzhiran
Copy link
Member

plz fix the code smells and security hotspots

@LuckyPigeon

This comment was marked as resolved.

@LuckyPigeon

This comment was marked as resolved.

@LuckyPigeon
Copy link
Contributor Author

@huangzhiran Done!

test_hint_command.md Outdated Show resolved Hide resolved
ioctl/newcmd/action/action_test.go Outdated Show resolved Hide resolved
@LuckyPigeon LuckyPigeon mentioned this pull request Sep 21, 2022
11 tasks
@huof6829
Copy link
Contributor

@LuckyPigeon please resolve conflict, thx.

@LuckyPigeon
Copy link
Contributor Author

@huof6829 Done!

@huof6829
Copy link
Contributor

@huof6829

Thx!

@sonarcloud
Copy link

sonarcloud bot commented Oct 13, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 2 Code Smells

No Coverage information No Coverage information
3.7% 3.7% Duplication

@huof6829 huof6829 merged commit 75cb0a1 into iotexproject:master Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants