[ioctl] modify did command parameters #3668

huof6829 · 2022-10-14T16:07:25Z

Description

modify action.Read() default parameters
use alias.IOAddress() instead

Fixes #(issue)

Type of change

Please delete options that are not relevant.

[] Bug fix (non-breaking change which fixes an issue)
[] New feature (non-breaking change which adds functionality)
[] Code refactor or improvement
[] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
[] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[] make test
[] fullsync
[] Other test (please specify)

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Checklist:

[] My code follows the style guidelines of this project
[] I have performed a self-review of my code
[] I have commented my code, particularly in hard-to-understand areas
[] I have made corresponding changes to the documentation
[] My changes generate no new warnings
[] I have added tests that prove my fix is effective or that my feature works
[] New and existing unit tests pass locally with my changes
[] Any dependent changes have been merged and published in downstream modules

codecov · 2022-10-14T16:16:25Z

Codecov Report

Merging #3668 (12646af) into master (263ff82) will decrease coverage by 0.51%.
The diff coverage is 84.82%.

❗ Current head 12646af differs from pull request most recent head 8859ede. Consider uploading reports for the commit 8859ede to get more accurate results

@@            Coverage Diff             @@
##           master    #3668      +/-   ##
==========================================
- Coverage   74.47%   73.95%   -0.52%     
==========================================
  Files         269      291      +22     
  Lines       23925    24692     +767     
==========================================
+ Hits        17818    18261     +443     
- Misses       5174     5498     +324     
  Partials      933      933

Impacted Files	Coverage Δ
action/protocol/context.go	`66.40% <0.00%> (-1.60%)`	⬇️
action/protocol/staking/candidate_statereader.go	`53.94% <ø> (-3.38%)`	⬇️
action/protocol/types.go	`0.00% <0.00%> (ø)`
api/web3server.go	`27.59% <0.00%> (-34.51%)`	⬇️
db/db_bolt.go	`68.53% <0.00%> (-3.60%)`	⬇️
ioctl/newcmd/action/actiontransfer.go	`100.00% <ø> (ø)`
ioctl/newcmd/action/stake2withdraw.go	`95.74% <ø> (ø)`
ioctl/newcmd/action/xrc20transferfrom.go	`100.00% <ø> (ø)`
server/itx/server.go	`62.20% <ø> (+2.20%)`	⬆️
action/protocol/staking/handlers.go	`74.47% <33.33%> (-0.64%)`	⬇️
... and 42 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Liuhaai · 2022-12-15T18:21:00Z

ioctl/newcmd/did/didgethash.go

 			bytecode, err := _didABI.Pack(_getHashName, []byte(args[1]))
 			if err != nil {
 				return errors.Wrap(err, "invalid bytecode")
 			}
-
-			result, err := action.Read(client, addr, "0", bytecode, contract, 20000000)
+			result, err := action.Read(client, addr, "0", bytecode, action.SignerFlagDefault, action.GasLimitFlagDefault)


why is contract changed to action.SignerFlagDefault?

contract is wrong parameter. contract is corresponding to addr. action.SignerFlagDefault is the right parameter according to cmd/ logic

sonarcloud · 2022-12-20T03:36:41Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

* move IsValidCandidateName to action package (#3706) * move IsValidCandidateName to action package * move IsValidCandidateName to action package * delete validations.go * update tests * delete ErrInvalidAmount in staking * Remove stale comment "This is an alpha release and is not ...." in all files (#3713) * remove stale comment * remove stale comment * remove nonce field (#3714) Co-authored-by: dustinxie <dahuaxie@gmail.com> * [evm] proper handle refundSnapshot and upgrade go-ethereum release (#3715) * [ioctl] modify did command parameters (#3668) * modify action.Read default parameters * use constant * use config.GasStation instead of config.API #3718 (#3721) Co-authored-by: dustinxie <dahuaxie@gmail.com> * [genesis] set Okhotsk to activate at 01-11-2023 12am UTC (#3720) * [tests] add more cases for gas refund (#3707) * add more cases for gas refund * remove debug flag Co-authored-by: dustinxie <dahuaxie@gmail.com> * [api] web3 rewarding action (#3691) * add rewarding execute action * add rewarding execute test * add commmet for public type * add builder test * complete web3 rewarding read * complete web3 rewarding read test * remove read api and receive create rewarding action enterance * add test to rlp tx test * change name * revert fix amount bug for deposit cost bug * change check error style * add entrance for web3 rewarding Co-authored-by: dustinxie <dahuaxie@gmail.com> * update mockgen (#3733) * [ioctl] use candidate.OperatorAddress to show probated delegates (#3727) Co-authored-by: dustinxie <dahuaxie@gmail.com> * [config] move config.Consensus to consensus package (#3735) * [action] validate candidate name (#3705) * Update release.yaml * [config] move config.Blocksync to blocksync package (#3736) * move config.BlockSync to blocksync package * remove def of BlockSync in config * rename newBlockSyncer to newBlockSyncerForTest * [ioctl] Build contract deploy command line into new ioctl (#3708) * [ioctl] build contract deploy command line into new ioctl * build unittest to cover the modification1~ * group iotex-core packages * remove stale comments Co-authored-by: huofei <68298506@qq.com> * [ioctl] Build contract invoke command line into new ioctl (#3709) * [ioctl] build contract invoke command line into new ioctl * build unittest to cover the modification1~ * remove stale comments Co-authored-by: huofei <68298506@qq.com> * [github] Update codeowner (#3742) * [ioctl] Build contract compile command line into new ioctl (#3676) * [ioctl] build contract compile command line into new ioctl Co-authored-by: huof6890 <68298506@qq.com> * [config] move config.API to api package (#3739) * move config.GasStation to gasstation package * move config.API to api package * make fields of testConfig to be private Co-authored-by: CoderZhi <thecoderzhi@gmail.com> * complete web3 intergrity test (#3743) * complete tests * complete requires * format * init monitor message framework * [ioctl/newcmd] fix node delegate run failed (#3729) * fix grpc error and show right datas * check chainMeta.Epoch * modify as currEpochNum * init broadcast framework * update broadcast framework * update broadcast framework * [ioctl] Build contract test bytecode command line into new ioctl (#3738) * [ioctl] build contract test bytecode command line into new ioctl * build unittest to cover the modification * format Co-authored-by: huofei <68298506@qq.com> * [ioctl] Build contract prepare command line into new ioctl (#3737) * [ioctl] build contract prepare command line into new ioctl * build unittest to cover the modification * fix commit * update assert message * update solc version * update solc message version * format * brew install solidity Co-authored-by: huofei <68298506@qq.com> * add node package to handle node info manager * update * Update release.yaml * Revert "adding .dockerignore file to fix git submodule builds (#3689)" (#3750) This reverts commit c14dcca. Co-authored-by: Jeremi [IoTeX] Rynkiewicz JRPC <63042547+jrynkiew@users.noreply.github.com> * update docker build command (#3751) * [actpool] Improve actqueue efficiency (#3377) * opt actpool.Add() * improve actqueue efficiency * add node info request and response message * remove delegate manager dependency * add message sign * add sign for node info message * fix unittest error * Update CODEOWNERS (#3754) * [rewarding] add active web3 rewarding settings (#3740) * add active web3 rewarding settings * check active when encoding is web3 * check active with deposit action * remove check logic to workingset * add check in API module * fix check validte web3 rewarding bug Co-authored-by: Haaai <55118568+Liuhaai@users.noreply.github.com> * add unittest for node * add pubkey in nodeinfo message * fix compile error * update go.mod Co-authored-by: millken <millken@gmail.com> Co-authored-by: huofei <68298506@qq.com> Co-authored-by: dustinxie <dahuaxie@gmail.com> Co-authored-by: Xueping Yang <xueping.yang@gmail.com> Co-authored-by: xianhuawei <258022429@qq.com> Co-authored-by: Jeremy Chou <lucky90322@gmail.com> Co-authored-by: Haaai <55118568+Liuhaai@users.noreply.github.com> Co-authored-by: CoderZhi <thecoderzhi@gmail.com> Co-authored-by: Jeremi [IoTeX] Rynkiewicz JRPC <63042547+jrynkiew@users.noreply.github.com>

modify action.Read default parameters

a165b1b

huof6829 requested a review from a team as a code owner October 14, 2022 16:07

huof6829 mentioned this pull request Oct 19, 2022

[ioctl] Build did deregister command line into new ioctl #3669

Merged

11 tasks

Merge branch 'master' into ioctl_did_uri

9f4c402

huangzhiran approved these changes Nov 3, 2022

View reviewed changes

huof6829 added 3 commits November 3, 2022 15:56

Merge branch 'master' into ioctl_did_uri

0794f68

Merge branch 'master' into ioctl_did_uri

b29c562

use constant

12646af

Liuhaai reviewed Dec 15, 2022

View reviewed changes

Liuhaai approved these changes Dec 19, 2022

View reviewed changes

Merge branch 'master' into ioctl_did_uri

8859ede

huof6829 merged commit 3ed15c6 into iotexproject:master Dec 20, 2022

huof6829 deleted the ioctl_did_uri branch December 20, 2022 04:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ioctl] modify did command parameters #3668

[ioctl] modify did command parameters #3668

huof6829 commented Oct 14, 2022

codecov bot commented Oct 14, 2022 •

edited

Loading

Liuhaai Dec 15, 2022 •

edited

Loading

huof6829 Dec 16, 2022

sonarcloud bot commented Dec 20, 2022

[ioctl] modify did command parameters #3668

[ioctl] modify did command parameters #3668

Conversation

huof6829 commented Oct 14, 2022

Description

Type of change

How Has This Been Tested?

Checklist:

codecov bot commented Oct 14, 2022 • edited Loading

Codecov Report

Liuhaai Dec 15, 2022 • edited Loading

Choose a reason for hiding this comment

huof6829 Dec 16, 2022

Choose a reason for hiding this comment

sonarcloud bot commented Dec 20, 2022

codecov bot commented Oct 14, 2022 •

edited

Loading

Liuhaai Dec 15, 2022 •

edited

Loading