[evm] proper handle refundSnapshot and upgrade go-ethereum release #3715

dustinxie · 2022-12-13T23:32:26Z

Description

as title.

Fixes #(issue)

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
[] New feature (non-breaking change which adds functionality)
[] Code refactor or improvement
[] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
[] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

make test
fullsync
[] Other test (please specify)

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules

dustinxie · 2022-12-13T23:38:03Z

action/protocol/execution/evm/evmstatedbadapter.go

+			} else {
+				break
+			}
+		}


in this fix: fcb8d7b, we need to clear snapshot >= n, when calling RevertToSnapshot(n)

dustinxie · 2022-12-13T23:38:54Z

go.mod

@@ -200,6 +200,6 @@ require (
 	gopkg.in/yaml.v3 v3.0.1 // indirect
 )

-replace github.com/ethereum/go-ethereum => github.com/iotexproject/go-ethereum v1.7.4-0.20221123031803-9e576f7b3e4b
+replace github.com/ethereum/go-ethereum => github.com/iotexproject/go-ethereum v0.4.2


tagged v0.4.2

codecov · 2022-12-13T23:57:16Z

Codecov Report

Merging #3715 (c3935ab) into master (263ff82) will decrease coverage by 0.48%.
The diff coverage is 80.74%.

@@            Coverage Diff             @@
##           master    #3715      +/-   ##
==========================================
- Coverage   74.47%   73.98%   -0.49%     
==========================================
  Files         269      291      +22     
  Lines       23925    24715     +790     
==========================================
+ Hits        17818    18286     +468     
- Misses       5174     5497     +323     
+ Partials      933      932       -1

Impacted Files	Coverage Δ
action/actctx.go	`84.37% <ø> (ø)`
action/action.go	`82.35% <ø> (ø)`
action/action_deserializer.go	`57.14% <ø> (ø)`
action/builder.go	`80.34% <ø> (ø)`
action/candidate_update.go	`93.02% <ø> (ø)`
action/claimreward.go	`58.33% <ø> (ø)`
action/consignment_transfer.go	`90.41% <ø> (ø)`
action/const.go	`100.00% <ø> (ø)`
action/depositreward.go	`58.33% <ø> (ø)`
action/execution.go	`83.78% <ø> (ø)`
... and 262 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

dustinxie · 2022-12-14T03:23:35Z

action/protocol/execution/evm/evmstatedbadapter.go

+			} else {
+				break
+			}
+		}


reason to move it here, is that L623 may return on "failed on load root", so we'd better clear snapshot before that

and accessList won't be activated before next HF, so it is safe to move it here

sonarcloud · 2022-12-19T18:22:51Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

* move IsValidCandidateName to action package (#3706) * move IsValidCandidateName to action package * move IsValidCandidateName to action package * delete validations.go * update tests * delete ErrInvalidAmount in staking * Remove stale comment "This is an alpha release and is not ...." in all files (#3713) * remove stale comment * remove stale comment * remove nonce field (#3714) Co-authored-by: dustinxie <dahuaxie@gmail.com> * [evm] proper handle refundSnapshot and upgrade go-ethereum release (#3715) * [ioctl] modify did command parameters (#3668) * modify action.Read default parameters * use constant * use config.GasStation instead of config.API #3718 (#3721) Co-authored-by: dustinxie <dahuaxie@gmail.com> * [genesis] set Okhotsk to activate at 01-11-2023 12am UTC (#3720) * [tests] add more cases for gas refund (#3707) * add more cases for gas refund * remove debug flag Co-authored-by: dustinxie <dahuaxie@gmail.com> * [api] web3 rewarding action (#3691) * add rewarding execute action * add rewarding execute test * add commmet for public type * add builder test * complete web3 rewarding read * complete web3 rewarding read test * remove read api and receive create rewarding action enterance * add test to rlp tx test * change name * revert fix amount bug for deposit cost bug * change check error style * add entrance for web3 rewarding Co-authored-by: dustinxie <dahuaxie@gmail.com> * update mockgen (#3733) * [ioctl] use candidate.OperatorAddress to show probated delegates (#3727) Co-authored-by: dustinxie <dahuaxie@gmail.com> * [config] move config.Consensus to consensus package (#3735) * [action] validate candidate name (#3705) * Update release.yaml * [config] move config.Blocksync to blocksync package (#3736) * move config.BlockSync to blocksync package * remove def of BlockSync in config * rename newBlockSyncer to newBlockSyncerForTest * [ioctl] Build contract deploy command line into new ioctl (#3708) * [ioctl] build contract deploy command line into new ioctl * build unittest to cover the modification1~ * group iotex-core packages * remove stale comments Co-authored-by: huofei <68298506@qq.com> * [ioctl] Build contract invoke command line into new ioctl (#3709) * [ioctl] build contract invoke command line into new ioctl * build unittest to cover the modification1~ * remove stale comments Co-authored-by: huofei <68298506@qq.com> * [github] Update codeowner (#3742) * [ioctl] Build contract compile command line into new ioctl (#3676) * [ioctl] build contract compile command line into new ioctl Co-authored-by: huof6890 <68298506@qq.com> * [config] move config.API to api package (#3739) * move config.GasStation to gasstation package * move config.API to api package * make fields of testConfig to be private Co-authored-by: CoderZhi <thecoderzhi@gmail.com> * complete web3 intergrity test (#3743) * complete tests * complete requires * format * init monitor message framework * [ioctl/newcmd] fix node delegate run failed (#3729) * fix grpc error and show right datas * check chainMeta.Epoch * modify as currEpochNum * init broadcast framework * update broadcast framework * update broadcast framework * [ioctl] Build contract test bytecode command line into new ioctl (#3738) * [ioctl] build contract test bytecode command line into new ioctl * build unittest to cover the modification * format Co-authored-by: huofei <68298506@qq.com> * [ioctl] Build contract prepare command line into new ioctl (#3737) * [ioctl] build contract prepare command line into new ioctl * build unittest to cover the modification * fix commit * update assert message * update solc version * update solc message version * format * brew install solidity Co-authored-by: huofei <68298506@qq.com> * add node package to handle node info manager * update * Update release.yaml * Revert "adding .dockerignore file to fix git submodule builds (#3689)" (#3750) This reverts commit c14dcca. Co-authored-by: Jeremi [IoTeX] Rynkiewicz JRPC <63042547+jrynkiew@users.noreply.github.com> * update docker build command (#3751) * [actpool] Improve actqueue efficiency (#3377) * opt actpool.Add() * improve actqueue efficiency * add node info request and response message * remove delegate manager dependency * add message sign * add sign for node info message * fix unittest error * Update CODEOWNERS (#3754) * [rewarding] add active web3 rewarding settings (#3740) * add active web3 rewarding settings * check active when encoding is web3 * check active with deposit action * remove check logic to workingset * add check in API module * fix check validte web3 rewarding bug Co-authored-by: Haaai <55118568+Liuhaai@users.noreply.github.com> * add unittest for node * add pubkey in nodeinfo message * fix compile error * update go.mod Co-authored-by: millken <millken@gmail.com> Co-authored-by: huofei <68298506@qq.com> Co-authored-by: dustinxie <dahuaxie@gmail.com> Co-authored-by: Xueping Yang <xueping.yang@gmail.com> Co-authored-by: xianhuawei <258022429@qq.com> Co-authored-by: Jeremy Chou <lucky90322@gmail.com> Co-authored-by: Haaai <55118568+Liuhaai@users.noreply.github.com> Co-authored-by: CoderZhi <thecoderzhi@gmail.com> Co-authored-by: Jeremi [IoTeX] Rynkiewicz JRPC <63042547+jrynkiew@users.noreply.github.com>

dustinxie requested a review from a team as a code owner December 13, 2022 23:32

dustinxie commented Dec 13, 2022

View reviewed changes

Liuhaai approved these changes Dec 14, 2022

View reviewed changes

dustinxie force-pushed the updateth branch from 923edf8 to 79d4f27 Compare December 14, 2022 03:21

dustinxie commented Dec 14, 2022

View reviewed changes

[evm] proper handle refundSnapshot and upgrade go-ethereum release

79d4f27

CoderZhi approved these changes Dec 14, 2022

View reviewed changes

dustinxie added 2 commits December 15, 2022 11:18

Merge branch 'master' into updateth

4e81b4c

Merge branch 'master' into updateth

c3935ab

dustinxie merged commit 4149d95 into master Dec 19, 2022

dustinxie deleted the updateth branch December 19, 2022 19:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[evm] proper handle refundSnapshot and upgrade go-ethereum release #3715

[evm] proper handle refundSnapshot and upgrade go-ethereum release #3715

dustinxie commented Dec 13, 2022

dustinxie Dec 13, 2022 •

edited

Loading

dustinxie Dec 13, 2022

codecov bot commented Dec 13, 2022 •

edited

Loading

dustinxie Dec 14, 2022 •

edited

Loading

sonarcloud bot commented Dec 19, 2022

[evm] proper handle refundSnapshot and upgrade go-ethereum release #3715

[evm] proper handle refundSnapshot and upgrade go-ethereum release #3715

Conversation

dustinxie commented Dec 13, 2022

Description

Type of change

How Has This Been Tested?

Checklist:

dustinxie Dec 13, 2022 • edited Loading

Choose a reason for hiding this comment

dustinxie Dec 13, 2022

Choose a reason for hiding this comment

codecov bot commented Dec 13, 2022 • edited Loading

Codecov Report

dustinxie Dec 14, 2022 • edited Loading

Choose a reason for hiding this comment

sonarcloud bot commented Dec 19, 2022

dustinxie Dec 13, 2022 •

edited

Loading

codecov bot commented Dec 13, 2022 •

edited

Loading

dustinxie Dec 14, 2022 •

edited

Loading