-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[api] support "input" field in web3 request params #3971
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3971 +/- ##
==========================================
+ Coverage 75.38% 76.15% +0.77%
==========================================
Files 303 330 +27
Lines 25923 28143 +2220
==========================================
+ Hits 19541 21432 +1891
- Misses 5360 5611 +251
- Partials 1022 1100 +78 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need hard fork?
confirmed that the three affected APIs are read-only, so a hard fork is not needed. |
SonarCloud Quality Gate failed. 0 Bugs No Coverage information Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
* support input/data field in web3 request * add test --------- Co-authored-by: CoderZhi <thecoderzhi@gmail.com>
* fix Dockerfile * [api] support "input" field in web3 request params (#3971) * support input/data field in web3 request * add test --------- Co-authored-by: CoderZhi <thecoderzhi@gmail.com> * set gprc MaxConnectionIdle to 5 min (#4023) * draft * [actpool] only expire tx with nonce > pendingNonce * implement replacing logic * fix accountpool update * unittest * delete account * place empty queue at the end * add unittest * address comments * Update actpool.go * address comments * Rebase queueworker.go --------- Co-authored-by: Dustin Xie <dahuaxie@gmail.com> Co-authored-by: Chen Chen <34592639+envestcc@users.noreply.github.com> Co-authored-by: envestcc <chen1233216@hotmail.com>
* fix Dockerfile * [api] support "input" field in web3 request params (#3971) * support input/data field in web3 request * add test --------- Co-authored-by: CoderZhi <thecoderzhi@gmail.com> * set gprc MaxConnectionIdle to 5 min (#4023) * draft * [actpool] only expire tx with nonce > pendingNonce * implement replacing logic * fix accountpool update * unittest * delete account * place empty queue at the end * add unittest * address comments * Update actpool.go * address comments * Rebase queueworker.go --------- Co-authored-by: Dustin Xie <dahuaxie@gmail.com> Co-authored-by: Chen Chen <34592639+envestcc@users.noreply.github.com> Co-authored-by: envestcc <chen1233216@hotmail.com>
Description
Fixes #3969
The following three web3 API support the latest Ethereum JSON-RPC specification, with parameters supporting
input
field:Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: