Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] support "input" field in web3 request params #3971

Merged
merged 4 commits into from
Nov 20, 2023

Conversation

envestcc
Copy link
Member

Description

Fixes #3969

The following three web3 API support the latest Ethereum JSON-RPC specification, with parameters supporting input field:

  • eth_call
  • eth_estimateGas
  • debug_traceCall

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 503 lines in your changes are missing coverage. Please review.

Comparison is base (e1f0636) 75.38% compared to head (6e1b181) 76.15%.
Report is 106 commits behind head on master.

Files Patch % Lines
blockindex/contractstaking/event_handler.go 67.23% 45 Missing and 13 partials ⚠️
action/protocol/staking/staking_statereader.go 69.76% 35 Missing and 17 partials ⚠️
action/protocol/execution/evm/evm.go 42.16% 47 Missing and 1 partial ⚠️
action/protocol/staking/protocol.go 33.33% 28 Missing ⚠️
...tion/protocol/staking/contractstake_bucket_type.go 0.00% 24 Missing ⚠️
blockindex/contractstaking/util.go 39.47% 22 Missing and 1 partial ⚠️
action/protocol/rewarding/fund.go 23.07% 19 Missing and 1 partial ⚠️
api/coreservice.go 69.69% 14 Missing and 6 partials ⚠️
api/websocket.go 0.00% 20 Missing ⚠️
action/protocol/execution/evm/evmstatedbadapter.go 0.00% 19 Missing ⚠️
... and 29 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3971      +/-   ##
==========================================
+ Coverage   75.38%   76.15%   +0.77%     
==========================================
  Files         303      330      +27     
  Lines       25923    28143    +2220     
==========================================
+ Hits        19541    21432    +1891     
- Misses       5360     5611     +251     
- Partials     1022     1100      +78     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@CoderZhi CoderZhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need hard fork?

@envestcc
Copy link
Member Author

envestcc commented Nov 20, 2023

do we need hard fork?

confirmed that the three affected APIs are read-only, so a hard fork is not needed.

Copy link

sonarcloud bot commented Nov 20, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
6.3% 6.3% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@CoderZhi CoderZhi merged commit 453a2b9 into iotexproject:master Nov 20, 2023
4 of 6 checks passed
@envestcc envestcc deleted the pr_estimategas branch November 20, 2023 05:24
CoderZhi added a commit that referenced this pull request Dec 19, 2023
* support input/data field in web3 request

* add test

---------

Co-authored-by: CoderZhi <thecoderzhi@gmail.com>
CoderZhi added a commit that referenced this pull request Jan 16, 2024
* fix Dockerfile

* [api] support "input" field in web3 request params (#3971)

* support input/data field in web3 request

* add test

---------

Co-authored-by: CoderZhi <thecoderzhi@gmail.com>

* set gprc MaxConnectionIdle to 5 min (#4023)

* draft

* [actpool] only expire tx with nonce > pendingNonce

* implement replacing logic

* fix accountpool update

* unittest

* delete account

* place empty queue at the end

* add unittest

* address comments

* Update actpool.go

* address comments

* Rebase queueworker.go

---------

Co-authored-by: Dustin Xie <dahuaxie@gmail.com>
Co-authored-by: Chen Chen <34592639+envestcc@users.noreply.github.com>
Co-authored-by: envestcc <chen1233216@hotmail.com>
dustinxie added a commit that referenced this pull request Jan 29, 2024
* fix Dockerfile

* [api] support "input" field in web3 request params (#3971)

* support input/data field in web3 request

* add test

---------

Co-authored-by: CoderZhi <thecoderzhi@gmail.com>

* set gprc MaxConnectionIdle to 5 min (#4023)

* draft

* [actpool] only expire tx with nonce > pendingNonce

* implement replacing logic

* fix accountpool update

* unittest

* delete account

* place empty queue at the end

* add unittest

* address comments

* Update actpool.go

* address comments

* Rebase queueworker.go

---------

Co-authored-by: Dustin Xie <dahuaxie@gmail.com>
Co-authored-by: Chen Chen <34592639+envestcc@users.noreply.github.com>
Co-authored-by: envestcc <chen1233216@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eth_estimateGas return revert error
3 participants