-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[grpc] Set MaxConnectionIdle to 5 min #4023
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
envestcc
requested review from
CoderZhi,
dustinxie,
Liuhaai and
millken
as code owners
December 19, 2023 02:14
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
CoderZhi
approved these changes
Dec 19, 2023
dustinxie
approved these changes
Dec 19, 2023
Liuhaai
approved these changes
Dec 19, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4023 +/- ##
==========================================
+ Coverage 75.38% 76.30% +0.92%
==========================================
Files 303 330 +27
Lines 25923 28261 +2338
==========================================
+ Hits 19541 21565 +2024
- Misses 5360 5599 +239
- Partials 1022 1097 +75 ☔ View full report in Codecov by Sentry. |
CoderZhi
pushed a commit
that referenced
this pull request
Dec 19, 2023
CoderZhi
added a commit
that referenced
this pull request
Jan 16, 2024
* fix Dockerfile * [api] support "input" field in web3 request params (#3971) * support input/data field in web3 request * add test --------- Co-authored-by: CoderZhi <thecoderzhi@gmail.com> * set gprc MaxConnectionIdle to 5 min (#4023) * draft * [actpool] only expire tx with nonce > pendingNonce * implement replacing logic * fix accountpool update * unittest * delete account * place empty queue at the end * add unittest * address comments * Update actpool.go * address comments * Rebase queueworker.go --------- Co-authored-by: Dustin Xie <dahuaxie@gmail.com> Co-authored-by: Chen Chen <34592639+envestcc@users.noreply.github.com> Co-authored-by: envestcc <chen1233216@hotmail.com>
dustinxie
added a commit
that referenced
this pull request
Jan 29, 2024
* fix Dockerfile * [api] support "input" field in web3 request params (#3971) * support input/data field in web3 request * add test --------- Co-authored-by: CoderZhi <thecoderzhi@gmail.com> * set gprc MaxConnectionIdle to 5 min (#4023) * draft * [actpool] only expire tx with nonce > pendingNonce * implement replacing logic * fix accountpool update * unittest * delete account * place empty queue at the end * add unittest * address comments * Update actpool.go * address comments * Rebase queueworker.go --------- Co-authored-by: Dustin Xie <dahuaxie@gmail.com> Co-authored-by: Chen Chen <34592639+envestcc@users.noreply.github.com> Co-authored-by: envestcc <chen1233216@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a client is idle for 5 minutes, grpc server send a GOAWAY to terminate the connection
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: