Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[grpc] Set MaxConnectionIdle to 5 min #4023

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

envestcc
Copy link
Member

Description

If a client is idle for 5 minutes, grpc server send a GOAWAY to terminate the connection

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [] make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

Copy link

sonarcloud bot commented Dec 19, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
2.9% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 515 lines in your changes are missing coverage. Please review.

Comparison is base (e1f0636) 75.38% compared to head (33186d5) 76.30%.
Report is 129 commits behind head on master.

Files Patch % Lines
blockindex/contractstaking/event_handler.go 67.23% 45 Missing and 13 partials ⚠️
action/protocol/staking/staking_statereader.go 69.76% 35 Missing and 17 partials ⚠️
action/protocol/execution/evm/evm.go 48.38% 47 Missing and 1 partial ⚠️
action/protocol/staking/protocol.go 33.33% 28 Missing ⚠️
...tion/protocol/staking/contractstake_bucket_type.go 0.00% 24 Missing ⚠️
api/coreservice.go 68.49% 17 Missing and 6 partials ⚠️
blockindex/contractstaking/util.go 39.47% 22 Missing and 1 partial ⚠️
action/protocol/rewarding/fund.go 23.07% 19 Missing and 1 partial ⚠️
api/websocket.go 0.00% 20 Missing ⚠️
blockindex/sgd_indexer.go 90.30% 12 Missing and 7 partials ⚠️
... and 29 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4023      +/-   ##
==========================================
+ Coverage   75.38%   76.30%   +0.92%     
==========================================
  Files         303      330      +27     
  Lines       25923    28261    +2338     
==========================================
+ Hits        19541    21565    +2024     
- Misses       5360     5599     +239     
- Partials     1022     1097      +75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@envestcc envestcc merged commit e5e3046 into iotexproject:master Dec 19, 2023
4 of 5 checks passed
CoderZhi pushed a commit that referenced this pull request Dec 19, 2023
CoderZhi added a commit that referenced this pull request Jan 16, 2024
* fix Dockerfile

* [api] support "input" field in web3 request params (#3971)

* support input/data field in web3 request

* add test

---------

Co-authored-by: CoderZhi <thecoderzhi@gmail.com>

* set gprc MaxConnectionIdle to 5 min (#4023)

* draft

* [actpool] only expire tx with nonce > pendingNonce

* implement replacing logic

* fix accountpool update

* unittest

* delete account

* place empty queue at the end

* add unittest

* address comments

* Update actpool.go

* address comments

* Rebase queueworker.go

---------

Co-authored-by: Dustin Xie <dahuaxie@gmail.com>
Co-authored-by: Chen Chen <34592639+envestcc@users.noreply.github.com>
Co-authored-by: envestcc <chen1233216@hotmail.com>
dustinxie added a commit that referenced this pull request Jan 29, 2024
* fix Dockerfile

* [api] support "input" field in web3 request params (#3971)

* support input/data field in web3 request

* add test

---------

Co-authored-by: CoderZhi <thecoderzhi@gmail.com>

* set gprc MaxConnectionIdle to 5 min (#4023)

* draft

* [actpool] only expire tx with nonce > pendingNonce

* implement replacing logic

* fix accountpool update

* unittest

* delete account

* place empty queue at the end

* add unittest

* address comments

* Update actpool.go

* address comments

* Rebase queueworker.go

---------

Co-authored-by: Dustin Xie <dahuaxie@gmail.com>
Co-authored-by: Chen Chen <34592639+envestcc@users.noreply.github.com>
Co-authored-by: envestcc <chen1233216@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants