Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delegate transfer ownership handler #4239

Merged
merged 16 commits into from
May 28, 2024
Merged

Add delegate transfer ownership handler #4239

merged 16 commits into from
May 28, 2024

Conversation

millken
Copy link
Contributor

@millken millken commented Apr 18, 2024

Description

Transfering delegate ownership to a new address PART 2

Add an identifier to the candidate to represent its voting address. This field defaults to null. When a new action is processed, if the field is null, it will be set to the original owner. Similarly, when getting this value, if it is null, return its owner field

Other changes:

  1. update CandidateRegister handler , the registered owner address cannot be the address in the Identifier list

Related PR:
#4236
#4239
#4245
#4250

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [] make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

@millken millken marked this pull request as ready for review April 19, 2024 09:07
@millken millken requested review from CoderZhi, Liuhaai, envestcc and a team as code owners April 19, 2024 09:07
@CoderZhi
Copy link
Collaborator

write description please!

action/protocol/staking/candidate.go Show resolved Hide resolved
action/protocol/staking/candidate.go Outdated Show resolved Hide resolved
action/protocol/staking/candidate_center.go Outdated Show resolved Hide resolved
action/protocol/staking/candidate_center.go Outdated Show resolved Hide resolved
@dustinxie
Copy link
Member

pls fix before merge

action/protocol/staking/handlers.go Outdated Show resolved Hide resolved
test/identityset/identityset.go Outdated Show resolved Hide resolved
test/identityset/identityset.go Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented May 28, 2024

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@envestcc envestcc merged commit d0ea5ae into iotexproject:master May 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants