-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add delegate transfer ownership handler #4239
Merged
envestcc
merged 16 commits into
iotexproject:master
from
millken:delegate_transfer_ownership_2
May 28, 2024
Merged
Add delegate transfer ownership handler #4239
envestcc
merged 16 commits into
iotexproject:master
from
millken:delegate_transfer_ownership_2
May 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustinxie
reviewed
Apr 18, 2024
millken
commented
Apr 18, 2024
millken
commented
Apr 18, 2024
millken
requested review from
CoderZhi,
Liuhaai,
envestcc and
a team
as code owners
April 19, 2024 09:07
CoderZhi
reviewed
Apr 21, 2024
write description please! |
This was referenced Apr 22, 2024
CoderZhi
reviewed
May 5, 2024
envestcc
reviewed
May 22, 2024
envestcc
reviewed
May 22, 2024
envestcc
approved these changes
May 23, 2024
1 task
dustinxie
reviewed
May 24, 2024
dustinxie
reviewed
May 24, 2024
dustinxie
reviewed
May 24, 2024
dustinxie
approved these changes
May 24, 2024
pls fix before merge |
CoderZhi
approved these changes
May 24, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Transfering delegate ownership to a new address PART 2
Add an
identifier
to the candidate to represent its voting address. This field defaults to null. When a new action is processed, if the field is null, it will be set to the original owner. Similarly, when getting this value, if it is null, return its owner fieldOther changes:
CandidateRegister
handler , the registered owner address cannot be the address in theIdentifier
listRelated PR:
#4236
#4239
#4245
#4250
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: