[staking] enable CandidateTransferOwnership at CandidateIdentifiedByOwner feature #4275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
envestcc
requested review from
CoderZhi,
dustinxie,
Liuhaai and
a team
as code owners
1 task
envestcc
force-pushed
the
delegate_transfer_ownership_3.5_cc
branch
from
0ef74d0
to
155ee80
Compare
envestcc
force-pushed
the
delegate_transfer_ownership_3.5_cc
branch
from
155ee80
to
90fd66d
Compare
dustinxie
reviewed
Jun 3, 2024
| @@ -98,3 +98,10 @@ func (p *Protocol) validateCandidateActivate(ctx context.Context, act *action.Ca | |||
| } | |||
| return nil | |||
| } | |||
|
|
|||
| func (p *Protocol) validateCandidateTransferOwnershipAction(ctx context.Context, act *action.CandidateTransferOwnership) error { | |||
| if protocol.MustGetFeatureCtx(ctx).CandidateIdentifiedByOwner { | |||
There was a problem hiding this comment.
add TODO: can be removed after hard-fork
dustinxie
reviewed
Jun 3, 2024
e2etest/native_staking_test.go
Outdated
| @@ -491,6 +545,7 @@ func TestNativeStaking(t *testing.T) { | |||
| cfg.Genesis.FbkMigrationBlockHeight = 1 | |||
| cfg.Genesis.TsunamiBlockHeight = 0 | |||
| cfg.Genesis.EndorsementWithdrawWaitingBlocks = 10 | |||
| cfg.Genesis.ToBeEnabledBlockHeight = 0 | |||
There was a problem hiding this comment.
should be a larger number to enable the feature?
dustinxie
reviewed
Jun 4, 2024
e2etest/native_staking_test.go
Outdated
| @@ -491,6 +545,7 @@ func TestNativeStaking(t *testing.T) { | |||
| cfg.Genesis.FbkMigrationBlockHeight = 1 | |||
| cfg.Genesis.TsunamiBlockHeight = 0 | |||
There was a problem hiding this comment.
each hard-fork height needs to be > previous ones
dustinxie
approved these changes
Jun 4, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make up missing parts for CandidateTransferOwnership
Related PR:
#4236
#4239
#4245
#4250
Fixes #(issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: