This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
feat: new request type and CAR mid-stream fail metrics #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
force-pushed
the
feat/new-boxo-metrics
branch
from
7ae7982
to
068516b
Compare
lidel
changed the title
|
Tested on staging and grafana, metrics work as expected, details in #104 (comment) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates to boxo with new metrics that allow us ro reason per-request type and mid-stream CAR failures.
👉 Details on how we can use them to close #104 in ipfs/boxo#288 (comment)
TODO
main