Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gw): add ipfs_http_gw_car_stream_fail_duration_seconds #312

Merged
merged 1 commit into from
May 22, 2023

Conversation

lidel
Copy link
Member

@lidel lidel commented May 22, 2023

This PR adds failure metrics to streaming response types (CAR and TAR)
to give us better visibility (histograms) into how long it takes for CAR to fail mid-stream.

Closes #288

Copy link
Contributor

@Jorropo Jorropo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #312 (f6bf439) into main (fee5f6b) will decrease coverage by 0.02%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #312      +/-   ##
==========================================
- Coverage   48.12%   48.10%   -0.02%     
==========================================
  Files         279      279              
  Lines       33511    33526      +15     
==========================================
+ Hits        16127    16128       +1     
- Misses      15696    15707      +11     
- Partials     1688     1691       +3     
Impacted Files Coverage Δ
gateway/handler.go 57.56% <ø> (ø)
gateway/handler_car.go 0.00% <0.00%> (ø)
gateway/handler_tar.go 0.00% <0.00%> (ø)
gateway/metrics.go 62.18% <100.00%> (+1.48%) ⬆️

... and 5 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gateway metric tracking partial failures
2 participants