This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
refactor: move files to root level #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves remaining files that contain root level commands to the root of the src directory. This makes it easier for new contributors to find things.
It also renames the `files-mfs` dir to `files` to reflect the fact that it lives in the "files" namespace currently.
BREAKING CHANGE: files in `src/files-regular` have moved to `src`. The `src/files-mfs` directory has been renamed to `src/files`. If you were previously requiring files from these directories e.g. `require('ipfs-http-client/src/files-regular/add')` then please be aware that they have moved.
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
|
@hugomrdias @achingbrain any chance you can review these changes? |
alanshaw
pushed a commit
that referenced
this pull request
Nov 12, 2019
depends on: * [ ] #1150 License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
1 task
hugomrdias
approved these changes
Nov 12, 2019
alanshaw
pushed a commit
that referenced
this pull request
Nov 12, 2019
depends on: * [ ] #1150 License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
alanshaw
pushed a commit
that referenced
this pull request
Nov 12, 2019
* refactor: convert block API to async/await depends on: * [ ] #1150 License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai> * feat: support the version param License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai> * refactor: convert DAG API to async/await License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai> * fix: add util to convert a single buffer to a form data object License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai> * fix: exported function
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves remaining files that contain root level commands to the root of the src directory. This makes it easier for new contributors to find things.
It also renames the
files-mfsdir tofilesto reflect the fact that it lives in the "files" namespace currently.BREAKING CHANGE: files in
src/files-regularhave moved tosrc. Thesrc/files-mfsdirectory has been renamed tosrc/files. If you were previously requiring files from these directories e.g.require('ipfs-http-client/src/files-regular/add')then please be aware that they have moved.