refactor: convert block API to async await

[alanshaw]

depends on:

• refactor: move files to root level #1150

[hugomrdias]

LGTM

notes:
still bugs me a bit all the

const searchParams = new URLSearchParams()
const searchParams = new URLSearchParams(options.searchParams)
if (options.format !== undefined) {
  searchParams.set('format', options.format)
}

if(options.format != null)

we have a couple of inconsistencies in there, maybe we could spend a little time finding a way to just pass options to ky instead of new URLSearchParams plus if clauses. @achingbrain you did a couple of changes to searchParams handling in ky upstream do you think we can do this already or the undefined/null is still an issue for us ?

[alanshaw]

const searchParams = new URLSearchParams()

Agree, that shouldn't happen, we should allow them to be overridden with options on every API call. Along with timeout, signal etc.

const searchParams = new URLSearchParams(options.searchParams)

URLSearchParams allows you to pass a URLSearchParams instance OR an object as the parameter. This allows users to pass their own query string params as an object or an instance of URLSearchParams AND also allows us to add mandatory/overridden parameters from args or other options.

if (options.format !== undefined) {
  searchParams.set('format', options.format)
}

if(options.format != null)

Sometimes we check for null/undefined because a falsy check on booleans or numbers that might be 0 is not good enough. It's a matter of preference if we only consider undefined as a "value" that doesn't get added to the query string. I've been using the != null because it includes null as well as undefined and 99.9% of the time you also would not want ?arg=null which is what happens when you pass null to URLSearchParams and stringify it.

[alanshaw]

@hugomrdias apologies I'm going to expand this PR to include the DAG API since it uses the block API.

[achingbrain]

I think we should apply the robustness principal - that is, all the if statements around URLSearchParams are verbose but it's good to only send what we know the server will support.