interface-ipfs-core config API spec compliant #307
Conversation
daviddias
commented
Jun 30, 2016
daviddias
commented
| } | ||
|
|
||
| if (!key) { | ||
| return send('config/show', null, null, null, true, callback) |
There was a problem hiding this comment.
Probably be valuable for the send method to accept a config argument rather than having a parameter list filled with nulls
There was a problem hiding this comment.
💯 agree. In fact, what I'm very much thinking is after merging the config-api PR into ipfs-api/ng branch, just make a PR to update how request-api.js works, break the tests (so that we don't have to run 300 tests while developing a single feature) and clean up whatever else I find.
There was a problem hiding this comment.
It is happening :) 43a1dfa
daviddias
force-pushed
the
config-api
branch
3 times, most recently
from
a318463
to
be4f964
Compare
| if (typeof config === 'object') { | ||
| config = streamifier.createReadStream(new Buffer(JSON.stringify(config))) | ||
| return send('config/replace', null, null, config, callback) | ||
| } |
There was a problem hiding this comment.
Just missing to make the config.replace tests to work. It seems that this was never working (see https://github.com/ipfs/js-ipfs-api/blob/master/test/api/config.spec.js#L123-L133), unfortunately.
The current problem is that the config never gets replaced and after we send the replace, the content type of the following config.get requests becomes text/plain instead of application/json
There was a problem hiding this comment.
Learned that this is an error in actual go-ipfs ipfs/kubo#2927
