This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
Reduce de complexity of the js-ipfs-api module #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -84,7 +85,7 @@ function requestAPI (config, path, args, qs, files, buffer, cb) { | |||
| const port = config.port ? `:${config.port}` : '' | |||
|
|
|||
| const opts = { | |||
| method: files ? 'POST' : 'GET', | |||
| method: 'POST', | |||
There was a problem hiding this comment.
Not all requests should be POST requests
There was a problem hiding this comment.
Let's check with @whyrusleeping, I've changed this after a conversation with him when we were debugging some npm-on-ipfs stuff.
There was a problem hiding this comment.
ping @whyrusleeping
daviddias
force-pushed
the
clean-madness
branch
from
e85c334
to
0c7a340
Compare
daviddias
force-pushed
the
ipfs-api/ng
branch
5 times, most recently
from
3d506cd
to
73078ea
Compare
daviddias
force-pushed
the
clean-madness
branch
2 times, most recently
from
9b513dd
to
0ca1a69
Compare
individually and reduce complexity inside ipfs-api
daviddias
force-pushed
the
clean-madness
branch
from
0ca1a69
to
108414b
Compare
…tead, migrate every call to it
|
@victorbjelkholm moving away from the argument flags :) #43a1dfa |
daviddias
force-pushed
the
clean-madness
branch
2 times, most recently
from
cf157bc
to
c6aef50
Compare
|
I've refactored all the test units that not require multiple nodes, to be come isolated. Will handle the remaining (3) with the interface-ipfs-core tests. |
daviddias
force-pushed
the
clean-madness
branch
from
c6aef50
to
0bee89f
Compare
daviddias
force-pushed
the
clean-madness
branch
from
0bee89f
to
11a166e
Compare
|
Why u no wait for CR? |
|
It was not merged to master, it was merged to the other PR branch ;) |
|
ahh okay :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the guts of js-ipfs-api are overly complex, making it hard to debug, to apply changes or even to develop, since we have to run every single test every single time. To make the experience more pleasant, this PR has the goals to:
What other things would you like to see that would make using the js-ipfs-code more sane?