Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

fix: remove external urls from addFromURL tests #834

Merged
merged 4 commits into from
Aug 15, 2018
Merged

fix: remove external urls from addFromURL tests #834

merged 4 commits into from
Aug 15, 2018

Commits on Aug 14, 2018

  1. fix: remove external URLs from addFromURL tests 

    Relying on external URLs makes our tests dependent on the availability and response time of these services as well as not being able to run without an internet connection. This PR removes those requests to external URLs and instead spins up test HTTP(s) servers as they are needed to serve the content that `ipfs.util.addFromURL` consumes.

resolves #803

License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>
    @alanshaw
    alanshaw committed Aug 14, 2018
    Configuration menu
    Copy the full SHA
    0f86d13 View commit details
    Browse the repository at this point in the history

  2. fix: assert the response received is the same as direct add 

    License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>
    @alanshaw
    alanshaw committed Aug 14, 2018
    Configuration menu
    Copy the full SHA
    3f19bce View commit details
    Browse the repository at this point in the history

  3. fix: no options for http createServer in Node.js 8 

    License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>
    @alanshaw
    alanshaw committed Aug 14, 2018
    Configuration menu
    Copy the full SHA
    0301d02 View commit details
    Browse the repository at this point in the history

  4. fix: remove .only 

    License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>
    @alanshaw
    alanshaw committed Aug 14, 2018
    Configuration menu
    Copy the full SHA
    eed55e3 View commit details
    Browse the repository at this point in the history